Skip to content

[stable18] Only copy the link when updating a share or no password was forced - #22338

Merged
rullzer merged 1 commit into
stable18from
backport/22322/stable18
Aug 21, 2020
Merged

[stable18] Only copy the link when updating a share or no password was forced#22338
rullzer merged 1 commit into
stable18from
backport/22322/stable18

Conversation

@backportbot-nextcloud

@backportbot-nextcloudbackportbot-nextcloudBot commented Aug 20, 2020

Copy link
Copy Markdown

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #22322

@skjnldsv

Copy link
Copy Markdown
Member

/compile amend /

@skjnldsvskjnldsv added the 3. to review Waiting for reviews label Aug 20, 2020
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@faily-bot

faily-botBot commented Aug 20, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32113: failure

jsunit

Show full log
PhantomJS 2.1.1 (Linux 0.0.0) LOG: 'JQMIGRATE: Migrate is installed, version 1.4.1'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Files.Sidebar initialized'
PhantomJS 2.1.1 (Linux 0.0.0) WARN: 'Proxying an event bus of version 1.1.2 with 0.2.1'
PhantomJS 2.1.1 (Linux 0.0.0) WARN: 'Proxying an event bus of version 1.1.2 with 0.2.1'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Sharing.ShareSearch initialized'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Sharing.ExternalLinkActions initialized'
PhantomJS 2.1.1 (Linux 0.0.0): Executed 847 of 851 (skipped 4) SUCCESS (12 secs / 11.151 secs)

acceptance-app-files

  • tests/acceptance/features/app-files.feature:108
Show full log
 Scenario: show shares # /drone/src/tests/acceptance/features/app-files.feature:108
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I share the link for "welcome.txt" # FilesAppSharingContext::iShareTheLinkFor()
When I open the "Shares" section # AppNavigationContext::iOpenTheSection()
Then I see that the current section is "Shares" # AppNavigationContext::iSeeThatTheCurrentSectionIs()
Then I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
Row for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)

acceptance-users

  • tests/acceptance/features/users.feature:35
Show full log
 Scenario: disable a user # /drone/src/tests/acceptance/features/users.feature:35
Given I act as Jane # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
And I see that the list of users contains the user user0 # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I open the actions menu for the user user0 # UsersSettingsContext::iOpenTheActionsMenuOf()
Row for user user0 in Users Settings could not be found
Actions menu for user user0 in Users Settings could not be found (NoSuchElementException)

@rullzerrullzer mentioned this pull request Aug 21, 2020
@rullzer
rullzer merged commit f80eaee into stable18Aug 21, 2020
@rullzer
rullzer deleted the backport/22322/stable18 branch August 21, 2020 08:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@skjnldsv@rullzer@nickvergessen