Skip to content

fix event icon sizes and text alignment - #22358

Merged
blizzz merged 2 commits into
masterfrom
fix/noid/flow-icon-size-and-alignment
Aug 24, 2020
Merged

fix event icon sizes and text alignment#22358
blizzz merged 2 commits into
masterfrom
fix/noid/flow-icon-size-and-alignment

Conversation

@blizzz

Copy link
Copy Markdown
Member

Before:

event-icon-too-large

After:

Screenshot_20200821_162217

(btw, yes, the typo in "Sent notification" is fixed in master)

@blizzz

Copy link
Copy Markdown
MemberAuthor

/compile /apps/workflowengine/

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
blizzzforce-pushed the fix/noid/flow-icon-size-and-alignment branch from 61433e1 to 6bdcbeaCompareAugust 21, 2020 14:28
@rullzer

Copy link
Copy Markdown
Member

/compile amend /

@npmbuildbot-nextcloud
npmbuildbot-nextcloudBotforce-pushed the fix/noid/flow-icon-size-and-alignment branch from 6bdcbea to 599b2fdCompareAugust 24, 2020 10:38
@blizzz
blizzzforce-pushed the fix/noid/flow-icon-size-and-alignment branch from 599b2fd to 6bdcbeaCompareAugust 24, 2020 10:45
@blizzz

Copy link
Copy Markdown
MemberAuthor

/compile /apps/workflowengine/

Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@blizzzblizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 24, 2020

@juliusknorrjuliusknorr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@faily-bot

faily-botBot commented Aug 24, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32239: failure

jsunit

Show full log
PhantomJS 2.1.1 (Linux 0.0.0) LOG: 'JQMIGRATE: Migrate is installed, version 1.4.1'
PhantomJS 2.1.1 (Linux 0.0.0) WARN: 'jQuery is deprecated: The global jQuery is deprecated. It will be updated to v3.x in Nextcloud 21. In later versions of Nextcloud it might be removed completely. Please ship your own.'
PhantomJS 2.1.1 (Linux 0.0.0) WARN: '$ is deprecated: The global jQuery is deprecated. It will be updated to v3.x in Nextcloud 21. In later versions of Nextcloud it might be removed completely. Please ship your own.'
PhantomJS 2.1.1 (Linux 0.0.0) WARN: 'Handlebars is deprecated: please ship your own, this will be removed in Nextcloud 20'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Files.Settings initialized'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Files.Sidebar initialized'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Sharing.ShareSearch initialized'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Sharing.ExternalLinkActions initialized'
PhantomJS 2.1.1 (Linux 0.0.0): Executed 847 of 850 (skipped 3) SUCCESS (11.371 secs / 10.831 secs)

acceptance-app-files

  • tests/acceptance/features/app-files.feature:262
Show full log
 Scenario: unmarking a file as favorite causes the file list to be sorted again # /drone/src/tests/acceptance/features/app-files.feature:262
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "A name alphabetically lower than welcome.txt" # FileListContext::iCreateANewFolderNamed()
And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
And I close the details view # FilesAppContext::iCloseTheDetailsView()
And I see that the details view is closed # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
And I mark "welcome.txt" as favorite # FileListContext::iMarkAsFavorite()
And I see that "welcome.txt" is marked as favorite # FileListContext::iSeeThatIsMarkedAsFavorite()
And I see that "welcome.txt" precedes "A name alphabetically lower than welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
When I unmark "welcome.txt" as favorite # FileListContext::iUnmarkAsFavorite()
Then I see that "welcome.txt" is not marked as favorite # FileListContext::iSeeThatIsNotMarkedAsFavorite()
Not favorited state icon for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)
And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()

@blizzz
blizzz merged commit bf162d0 into masterAug 24, 2020
@blizzz
blizzz deleted the fix/noid/flow-icon-size-and-alignment branch August 24, 2020 12:11
@rullzerrullzer mentioned this pull request Aug 25, 2020
19 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@blizzz@rullzer@jancborchardt@juliusknorr@MorrisJobke