[stable17] Make legacy format opt-in

[rullzer]

Very simplified backport of #22381
The scanning etc is not there but it does allow people runing 17 to disable the old version.

[rullzer]

/backport to stable18

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32261: failure

webpack-build

• I'm a little sad 🤖 and was not able to find the logs for this failed job - please improve me at https://github.com/MorrisJobke/drone-logs to provide this to you

nodb

• I'm a little sad 🤖 and was not able to find the logs for this failed job - please improve me at https://github.com/MorrisJobke/drone-logs to provide this to you

mysql8.0-php7.2

Show full log

There was 1 failure:
1) Test\Files\Cache\Wrapper\CachePermissionsMaskTest::testSearchQueryByTag
Failed asserting that 0 matches expected 3.
/drone/src/tests/lib/Files/Cache/CacheTest.php:366

integration-sharing-v1

• build/integration/features/sharing-v1.feature:58

Show full log

 Scenario: Creating a new mail share # /drone/src/build/integration/features/sharing-v1.feature:58
Given dummy mail server is listening # FeatureContext::dummyMailServerIsListening()
[Mon Aug 24 16:33:37 2020] 127.0.0.1:54296 [404]: /ocs/v2.php/cloud/users/user0
[Mon Aug 24 16:33:38 2020] 127.0.0.1:54312 [200]: /ocs/v1.php/cloud/users
[Mon Aug 24 16:33:38 2020] 127.0.0.1:54342 [200]: /ocs/v1.php/cloud/users/user0
[Mon Aug 24 16:33:38 2020] 127.0.0.1:54380 [200]: /ocs/v2.php/cloud/users/user0
And user "user0" exists # FeatureContext::assureUserExists()
And As an "user0" # FeatureContext::asAn()
[Mon Aug 24 16:33:38 2020] {"Exception":"Swift_TransportException","Message":"Connection could not be established with host 127.0.0.1 [Connection refused #111]","Code":0,"Trace":[{"file":"\/drone\/src\/3rdparty\/swiftmailer\/swiftmailer\/lib\/classes\/Swift\/Transport\/StreamBuffer.php","line":58,"function":"establishSocketConnection","class":"Swift_Transport_StreamBuffer","type":"->","args":[]},{"file":"\/drone\/src\/3rdparty\/swiftmailer\/swiftmailer\/lib\/classes\/Swift\/Transport\/AbstractSmtpTransport.php","line":143,"function":"initialize","class":"Swift_Transport_StreamBuffer","type":"->","args":[{"protocol":"","host":"127.0.0.1","port":25,"timeout":10,"blocking":1,"tls":false,"type":1,"stream_context_options":[]}]},{"file":"\/drone\/src\/3rdparty\/swiftmailer\/swiftmailer\/lib\/classes\/Swift\/Mailer.php","line":65,"function":"start","class":"Swift_Transport_AbstractSmtpTransport","type":"->","args":[]},{"file":"\/drone\/src\/lib\/private\/Mail\/Mailer.php","line":185,"function":"send","class":"Swift_Mailer","type":"->","args":[{"__class__":"Swift_Message"},[]]},{"file":"\/drone\/src\/apps\/sharebymail\/lib\/ShareByMailProvider.php","line":444,"function":"send","class":"OC\\Mail\\Mailer","type":"->","args":[{"__class__":"OC\\Mail\\Message"}]},{"file":"\/drone\/src\/apps\/sharebymail\/lib\/ShareByMailProvider.php","line":356,"function":"sendMailNotification","class":"OCA\\ShareByMail\\ShareByMailProvider","type":"->","args":["welcome.txt","http:\/\/localhost:8080\/index.php\/s\/rjBBgxjKEC9rNa4","user0","dumy@test.com",null]},{"file":"\/drone\/src\/apps\/sharebymail\/lib\/ShareByMailProvider.php","line":186,"function":"createMailShare","class":"OCA\\ShareByMail\\ShareByMailProvider","type":"->","args":[{"__class__":"OC\\Share20\\Share"}]},{"file":"\/drone\/src\/lib\/private\/Share20\/Manager.php","line":700,"function":"create","class":"OCA\\ShareByMail\\ShareByMailProvider","type":"->","args":[{"__class__":"OC\\Share20\\Share"}]},{"file":"\/drone\/src\/apps\/files_sharing\/lib\/Controller\/ShareAPIController.php","line":577,"function":"createShare","class":"OC\\Share20\\Manager","type":"->","args":[{"__class__":"OC\\Share20\\Share"}]},{"file":"\/drone\/src\/lib\/private\/AppFramework\/Http\/Dispatcher.php","line":170,"function":"createShare","class":"OCA\\Files_Sharing\\Controller\\ShareAPIController","type":"->","args":[{"__class__":"OC\\Files\\Node\\File"},19,4,"dumy@test.com","false","",null,"",""]},{"file":"\/drone\/src\/lib\/private\/AppFramework\/Http\/Dispatcher.php","line":99,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\Files_Sharing\\Controller\\ShareAPIController"},"createShare"]},{"file":"\/drone\/src\/lib\/private\/AppFramework\/App.php","line":126,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\Files_Sharing\\Controller\\ShareAPIController"},"createShare"]},{"file":"\/drone\/src\/lib\/private\/AppFramework\/Routing\/RouteActionHandler.php","line":47,"function":"main","class":"OC\\AppFramework\\App","type":"::","args":["OCA\\Files_Sharing\\Controller\\ShareAPIController","createShare",{"__class__":"OC\\AppFramework\\DependencyInjection\\DIContainer"},{"_route":"ocs.files_sharing.ShareAPI.createShare"}]},{"function":"__invoke","class":"OC\\AppFramework\\Routing\\RouteActionHandler","type":"->","args":[{"_route":"ocs.files_sharing.ShareAPI.createShare"}]},{"file":"\/drone\/src\/lib\/private\/Route\/Router.php","line":297,"function":"call_user_func","args":[{"__class__":"OC\\AppFramework\\Routing\\RouteActionHandler"},{"_route":"ocs.files_sharing.ShareAPI.createShare"}]},{"file":"\/drone\/src\/ocs\/v1.php","line":82,"function":"match","class":"OC\\Route\\Router","type":"->","args":["\/ocsapp\/apps\/files_sharing\/api\/v1\/shares"]}],"File":"\/drone\/src\/3rdparty\/swiftmailer\/swiftmailer\/lib\/classes\/Swift\/Transport\/StreamBuffer.php","Line":269,"CustomMessage":"Failed to send share by mail."}
[Mon Aug 24 16:33:38 2020] 127.0.0.1:54386 [401]: /ocs/v1.php/apps/files_sharing/api/v1/shares
When creating a share with # FeatureContext::creatingShare()
| path | welcome.txt |
| shareType | 4 |
| shareWith | dumy@test.com |
Then the OCS status code should be "100" # FeatureContext::theOCSStatusCodeShouldBe()
Failed asserting that SimpleXMLElement Object &000000007c259723000000002599b869 (
0 => '403'
) matches expected '100'.
And the HTTP status code should be "200" # FeatureContext::theHTTPStatusCodeShouldBe()
And last share can be downloaded # FeatureContext::lastShareCanBeDownloaded()
[Mon Aug 24 16:33:39 2020] 127.0.0.1:54448 [200]: /ocs/v1.php/cloud/users/user0
[Mon Aug 24 16:33:39 2020] 127.0.0.1:54500 [404]: /ocs/v2.php/cloud/users/user0
[Mon Aug 24 16:33:39 2020] Login failed: 'user0' (Remote IP: '127.0.0.1')
[Mon Aug 24 16:33:39 2020] 127.0.0.1:54510 [401]: /remote.php/webdav/myFileToComment.txt
[Mon Aug 24 16:33:39 2020] 127.0.0.1:54512 [207]: /remote.php/dav/systemtags/
[Mon Aug 24 16:33:39 2020] Login failed: 'user0' (Remote IP: '127.0.0.1')
[Mon Aug 24 16:33:39 2020] 127.0.0.1:54522 [401]: /remote.php/webdav/myFileToTag.txt
[Mon Aug 24 16:33:39 2020] 127.0.0.1:54526 [404]: /remote.php/dav/addressbooks/users/admin/MyAddressbook
[Mon Aug 24 16:33:39 2020] 127.0.0.1:54538 [404]: /remote.php/dav/calendars/admin/MyCalendar