Uh oh!
There was an error while loading. Please reload this page.
Dashboard polishing - #22392
Merged
Merged
Conversation
juliusknorr
commented
Aug 24, 2020
Member
- Add loading indicator until widgets are mounted
- Add class to handle styling when body has been scrolled
Closed
jancborchardtforce-pushed
the
bugfix/noid/dashboard-loading-til-moutned
branch
from
August 24, 2020 19:27
1d39a3b to
4dbdbd0Comparejancborchardt
approved these changes
Aug 24, 2020
jancborchardt
left a comment
Member
There was a problem hiding this comment.
Added the fade below navigation when scrolled, rebased → good to go from my view. :)
jancborchardt
commented
Aug 24, 2020
Member
Added another fix for Safari background blur since the -webkit prefix is needed as per https://caniuse.com/#search=backdrop-filter |
nickvergessen
commented
Aug 25, 2020
Member
Forgot to build after that @jancborchardt ? |
jancborchardt
commented
Aug 25, 2020
Member
Yes, I thought we would use the compile bot for that once it’s all reviewed. Fine anyway :) |
nickvergessen
approved these changes
Aug 25, 2020
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
rullzerforce-pushed
the
bugfix/noid/dashboard-loading-til-moutned
branch
from
August 25, 2020 18:31
4a1b01e to
d0297d5Comparerullzer
commented
Aug 25, 2020
Member
/compile amend / |
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
npmbuildbot-nextcloudBotforce-pushed
the
bugfix/noid/dashboard-loading-til-moutned
branch
from
August 25, 2020 18:42
d0297d5 to
e4df8b6Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.