Skip to content

show better quota warning for group folders and external storage - #22421

Merged
rullzer merged 2 commits into
masterfrom
group-folder-quota-warning
Aug 26, 2020
Merged

show better quota warning for group folders and external storage#22421
rullzer merged 2 commits into
masterfrom
group-folder-quota-warning

Conversation

@icewind1991

Copy link
Copy Markdown
Member

instead of showing the generic 'Your storage is full' message, better explain that it's the group folder/external storage that is full

Before:
image

After:
image

instead of showing the generic 'Your storage is full' message, better explain that it's the group folder/external storage that is full
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991icewind1991 added the 3. to review Waiting for reviews label Aug 25, 2020
@icewind1991icewind1991 added this to the Nextcloud 20 milestone Aug 25, 2020

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes! 👌

@icewind1991

Copy link
Copy Markdown
MemberAuthor

/backport to stable19

@icewind1991

Copy link
Copy Markdown
MemberAuthor

/backport to stable18

@rullzer

Copy link
Copy Markdown
Member

CI doesn't seem ahppy

Signed-off-by: Robin Appelman <robin@icewind.nl>
@nextcloudnextcloud deleted a comment from faily-botBotAug 26, 2020
@faily-bot

faily-botBot commented Aug 26, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32342: failure

acceptance-app-files

  • tests/acceptance/features/app-files.feature:262
Show full log
 Scenario: unmarking a file as favorite causes the file list to be sorted again # /drone/src/tests/acceptance/features/app-files.feature:262
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "A name alphabetically lower than welcome.txt" # FileListContext::iCreateANewFolderNamed()
And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
And I close the details view # FilesAppContext::iCloseTheDetailsView()
And I see that the details view is closed # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
And I mark "welcome.txt" as favorite # FileListContext::iMarkAsFavorite()
And I see that "welcome.txt" is marked as favorite # FileListContext::iSeeThatIsMarkedAsFavorite()
And I see that "welcome.txt" precedes "A name alphabetically lower than welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
When I unmark "welcome.txt" as favorite # FileListContext::iUnmarkAsFavorite()
Then I see that "welcome.txt" is not marked as favorite # FileListContext::iSeeThatIsNotMarkedAsFavorite()
Not favorited state icon for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)
And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()

@icewind1991

Copy link
Copy Markdown
MemberAuthor

fixed

@rullzerrullzer mentioned this pull request Aug 26, 2020
19 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@icewind1991@rullzer@skjnldsv