Skip to content

User-status: Fix icon coloring - #22425

Merged
georgehrke merged 1 commit into
masterfrom
bugfix/noid/status_icons_coloring
Aug 26, 2020
Merged

User-status: Fix icon coloring#22425
georgehrke merged 1 commit into
masterfrom
bugfix/noid/status_icons_coloring

Conversation

@georgehrke

Copy link
Copy Markdown
Member

1830A8C0-6F7B-4646-B931-B6B3BEFA026B

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@faily-bot

faily-botBot commented Aug 25, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32305: failure

acceptance-app-files

  • tests/acceptance/features/app-files.feature:262
Show full log
 Scenario: unmarking a file as favorite causes the file list to be sorted again # /drone/src/tests/acceptance/features/app-files.feature:262
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "A name alphabetically lower than welcome.txt" # FileListContext::iCreateANewFolderNamed()
And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
And I close the details view # FilesAppContext::iCloseTheDetailsView()
And I see that the details view is closed # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
And I mark "welcome.txt" as favorite # FileListContext::iMarkAsFavorite()
And I see that "welcome.txt" is marked as favorite # FileListContext::iSeeThatIsMarkedAsFavorite()
And I see that "welcome.txt" precedes "A name alphabetically lower than welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
When I unmark "welcome.txt" as favorite # FileListContext::iUnmarkAsFavorite()
Then I see that "welcome.txt" is not marked as favorite # FileListContext::iSeeThatIsNotMarkedAsFavorite()
Not favorited state icon for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)
And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()

}

@include icon-black-white('user-status-invisible', 'user_status', 3);
// TODO: debug why icon-black-white does not work here

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostlikely because of the invert filter that is in place on the header

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, i checked the compiled CSS and it also contains the wrong color for the icon var.

@rullzerrullzer mentioned this pull request Aug 26, 2020
19 tasks
@georgehrkegeorgehrke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 26, 2020
@georgehrke
georgehrke merged commit 9ff7f58 into masterAug 26, 2020
@georgehrke
georgehrke deleted the bugfix/noid/status_icons_coloring branch August 26, 2020 20:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishfeature: status

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@georgehrke@nickvergessen@juliusknorr