Change free space calculation

[kesselb]

Close#22475

If neither $userTrashbinSize nor $systemTrashbinSize are defined we have: $configuredTrashbinSize = (-1 < 0) ? -1 : -1;, (bool)-1 is true and the freespace is always-1 - $trashbinSize.

That should work but no idea how it should be ;)

[rullzer]

Good catch

[kesselb]

Are the trashbin tests failing on master too?

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32529: failure

mysql8.0-php7.2

Show full log

There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
--
There were 2 failures:
1) Test\Files\ObjectStore\ObjectStoreStorageTest::testCopyOverWriteDirectoryOverFile
Failed asserting that false matches expected 'foo'.
/drone/src/tests/lib/Files/Storage/Storage.php:582
2) OCA\Files_Sharing\Tests\SharedMountTest::testPermissionMovedGroupShare with data set #74 ('folder', 17, 5)
Failed asserting that false is true.
/drone/src/apps/files_sharing/tests/SharedMountTest.php:367

[kesselb]

Mockageddon 🙈

[rullzer]

/backport to stable19

[rullzer]

/backport to stable18

[rullzer]

/backport to stable17

[backportbot-nextcloud]

The backport to stable17 failed. Please do this backport manually.