Uh oh!
There was an error while loading. Please reload this page.
Fix dashboard statuses toggling - #22531
Merged
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
julien-ncforce-pushed
the
fix/save-statuses
branch
from
September 1, 2020 14:11
0cb0452 to
0f7aeb2Comparejulien-nc
commented
Sep 1, 2020
MemberAuthor
@juliushaertl Right. Just to be clear, I think $statuses = ($statuses && count($statuses) > 0) ? $statuses : ['weather' => true];is necessary to make sure the case of having '{}' stored in preferences is handled safely. |
Uh oh!
There was an error while loading. Please reload this page.
julien-ncforce-pushed
the
fix/save-statuses
branch
from
September 1, 2020 14:39
0f7aeb2 to
c23949dComparejuliusknorr
approved these changes
Sep 2, 2020
…t in UI Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
julien-ncforce-pushed
the
fix/save-statuses
branch
from
September 4, 2020 16:20
c23949d to
e8f37ddCompare🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 32662: failureacceptance-app-files
Show full log |
skjnldsv
approved these changes
Sep 4, 2020
julien-nc
commented
Sep 4, 2020
MemberAuthor
/compile amend / |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix empty php array becoming an array instead of an object when passed to UI. This was preventing statuses state saving if default value was loaded.
refs #22468