Skip to content

Adapt status menu styles to nc/vue 2.6 - #22540

Merged
skjnldsv merged 1 commit into
masterfrom
bugfix/noid/fix_status_nc2.6_regressions
Sep 4, 2020
Merged

Adapt status menu styles to nc/vue 2.6#22540
skjnldsv merged 1 commit into
masterfrom
bugfix/noid/fix_status_nc2.6_regressions

Conversation

@georgehrke

@georgehrkegeorgehrke commented Sep 1, 2020

Copy link
Copy Markdown
Member

Follow up for #22111

BeforeAfter
beforeafter

@georgehrkegeorgehrke added the 2. developing Work in progress label Sep 1, 2020
@georgehrkegeorgehrke added this to the Nextcloud 20 milestone Sep 1, 2020
This was referenced Sep 3, 2020
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke
georgehrkeforce-pushed the bugfix/noid/fix_status_nc2.6_regressions branch from 20189b6 to 4bc5dccCompareSeptember 3, 2020 14:16
@georgehrkegeorgehrke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 3, 2020
@georgehrke
georgehrke marked this pull request as ready for review September 3, 2020 14:17
@faily-bot

faily-botBot commented Sep 3, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32592: failure

mariadb10.1-php7.2

Show full log
There was 1 error:
1) Test\Files\Storage\Wrapper\PermissionsMaskTest::testScanNewFiles
Error: Call to a member function getPermissions() on boolean
/drone/src/tests/lib/Files/Storage/Wrapper/PermissionsMaskTest.php:117
--
There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

acceptance-app-files-sharing

  • tests/acceptance/features/app-files-sharing.feature:338
Show full log
 Scenario: sharee can revoke create permission from reshare after the sharer disabled it # /drone/src/tests/acceptance/features/app-files-sharing.feature:338
Given I act as John # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I act as Jane # ActorContext::iActAs()
And I am logged in # LoginPageContext::iAmLoggedIn()
And I act as Jim # ActorContext::iActAs()
And I am logged in as "user1" # LoginPageContext::iAmLoggedInAs()
And I act as John # ActorContext::iActAs()
And I create a new folder named "Shared folder" # FileListContext::iCreateANewFolderNamed()
And I see that the file list contains a file named "Shared folder" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
And I share "Shared folder" with "user0" # FilesAppSharingContext::iShareWith()
And I see that the file is shared with "user0" # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
And I act as Jane # ActorContext::iActAs()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
And I share "Shared folder" with "user1" # FilesAppSharingContext::iShareWith()
And I see that the file is shared with "user1" # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
And I act as John # ActorContext::iActAs()
And I set the share with "user0" as not creatable # FilesAppSharingContext::iSetTheShareWithAsNotCreatable()
And I see that "user0" can not create in the share # FilesAppSharingContext::iSeeThatCanNotCreateInTheShare()
And I act as Jim # ActorContext::iActAs()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
And I enter in the folder named "Shared folder" # FileListContext::iEnterInTheFolderNamed()
And I create a new folder named "Subfolder" # FileListContext::iCreateANewFolderNamed()
And I see that the file list contains a file named "Subfolder" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
When I act as Jane # ActorContext::iActAs()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
And I open the details view for "Shared folder" # FileListContext::iOpenTheDetailsViewFor()
And I see that the details view is open # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
And I open the "Sharing" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
And I see that the "Sharing" tab in the details view is eventually loaded # FilesAppContext::iSeeThatTheTabInTheDetailsViewIsEventuallyLoaded()
And I set the share with "user1" as not creatable # FilesAppSharingContext::iSetTheShareWithAsNotCreatable()
Then I see that "user1" can not create in the share # FilesAppSharingContext::iSeeThatCanNotCreateInTheShare()
And I see that "user1" can not be allowed to create in the share # FilesAppSharingContext::iSeeThatCanNotBeAllowedToCreateInTheShare()
And I act as Jim # ActorContext::iActAs()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
And I enter in the folder named "Shared folder" # FileListContext::iEnterInTheFolderNamed()
And I see that it is not possible to create new files # FileListContext::iSeeThatItIsNotPossibleToCreateNewFiles()
Failed asserting that true is false.

@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 4, 2020
@skjnldsv
skjnldsv merged commit d9b3c75 into masterSep 4, 2020
@skjnldsv
skjnldsv deleted the bugfix/noid/fix_status_nc2.6_regressions branch September 4, 2020 08:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@georgehrke@nickvergessen@skjnldsv