Skip to content

[stable18] Fix app password updating out of bounds - #22570

Merged
rullzer merged 1 commit into
stable18from
backport/22524/stable18
Sep 4, 2020
Merged

[stable18] Fix app password updating out of bounds#22570
rullzer merged 1 commit into
stable18from
backport/22524/stable18

Conversation

@backportbot-nextcloud

@backportbot-nextcloudbackportbot-nextcloudBot commented Sep 3, 2020•
edited
Loading

Copy link
Copy Markdown

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #22524

@backportbot-nextcloudbackportbot-nextcloudBot added this to the Nextcloud 18.0.10 milestone Sep 3, 2020
ChristophWurst
ChristophWurst requested changes Sep 4, 2020
View reviewed changes
Comment threadlib/private/Server.php
@ChristophWurstChristophWurst added the 1. to develop Accepted and waiting to be taken care of label Sep 4, 2020
@rullzerrullzer mentioned this pull request Sep 4, 2020
Merged
@rullzer
Fix app password updating out of bounds
87a66c8
When your password changes out of bounds your Nextcloud tokens will
become invalid. There is no real way around that. However we should make
sure that if you successfully log in again your passwords are all
updates
* Added event listener to the PostLoggedInEvent so that we can act on it
- Only if it is not a token login
* Make sure that we actually reset the invalid state when we update a
token. Else it keeps being marked invalid and thus not used.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer
rullzerforce-pushed the backport/22524/stable18 branch from d5be94b to 87a66c8CompareSeptember 4, 2020 07:18
@faily-bot

faily-botBot commented Sep 4, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32627: failure

sqlite

Show full log
There was 1 error:
1) OCA\Files_Sharing\Tests\EtagPropagationTest::testRecipientDeleteInShare
Error: Call to a member function getMountPoint() on null
/drone/src/lib/private/Share20/Manager.php:305
/drone/src/lib/private/Share20/Manager.php:707
/drone/src/apps/files_sharing/tests/EtagPropagationTest.php:142
/drone/src/apps/files_sharing/tests/PropagationTestCase.php:42
--
There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

@rullzer
rullzer merged commit ce93aaf into stable18Sep 4, 2020
@rullzer
rullzer deleted the backport/22524/stable18 branch September 4, 2020 10:26
@MorrisJobkeMorrisJobke mentioned this pull request Sep 9, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@kesselbkesselbAwaiting requested review from kesselb
@MorrisJobkeMorrisJobkeAwaiting requested review from MorrisJobke
@nickvergessennickvergessenAwaiting requested review from nickvergessen

Assignees

No one assigned

Labels

1. to developAccepted and waiting to be taken care ofbug

Projects

None yet

Milestone

Nextcloud 18.0.9

Development

Successfully merging this pull request may close these issues.

2 participants

@rullzer@ChristophWurst