Skip to content

Fix reading empty files from objectstorage - #22651

Merged
rullzer merged 1 commit into
masterfrom
fix/s3/empty_files
Sep 9, 2020
Merged

Fix reading empty files from objectstorage#22651
rullzer merged 1 commit into
masterfrom
fix/s3/empty_files

Conversation

@rullzer

@rullzerrullzer commented Sep 7, 2020

Copy link
Copy Markdown
Member

Since we try to do range requests this will fail hard.
However since empty files are not that interesting to read anyways we
just read from an emptry memory stream.

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

@rullzerrullzer added bug 3. to review Waiting for reviews labels Sep 7, 2020
@rullzerrullzer added this to the Nextcloud 20 milestone Sep 7, 2020
MorrisJobke
MorrisJobke approved these changes Sep 7, 2020
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@rullzerrullzer mentioned this pull request Sep 8, 2020
Merged
13 tasks
@rullzer
Fix reading empty files from objectstorage
bb06b6c
Since we try to do range requests this will fail hard.
However since empty files are not that interesting to read anyways we
just read from an emptry memory stream.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@faily-bot

faily-botBot commented Sep 9, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32902: failure

mariadb10.1-php7.2

Show full log
There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
--
There was 1 failure:
1) OCA\DAV\Tests\unit\CardDAV\CardDavBackendTest::testSearch with data set #0 ('John', array('FN'), array(), array(array('uri0', 'John Doe'), array('uri1', 'John M. Doe')))
Failed asserting that 1 is identical to 2.
/drone/src/apps/dav/tests/unit/CardDAV/CardDavBackendTest.php:746

@rullzer
rullzer merged commit e7f0348 into masterSep 9, 2020
@rullzer
rullzer deleted the fix/s3/empty_files branch September 9, 2020 19:44
@rullzer

rullzer commented Sep 9, 2020

Copy link
Copy Markdown
MemberAuthor

/backport to stable19

@rullzer

rullzer commented Sep 9, 2020

Copy link
Copy Markdown
MemberAuthor

/backport to stable18

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Sep 9, 2020
Merged
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Sep 9, 2020
Merged
@solracsfsolracsf mentioned this pull request Sep 10, 2020
Closed
@solracsfsolracsf mentioned this pull request Oct 1, 2020
Closed
@kesselbkesselb mentioned this pull request Oct 8, 2020
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@juliusknorrjuliusknorrjuliusknorr approved these changes
@icewind1991icewind1991Awaiting requested review from icewind1991

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Milestone

Nextcloud 20

Development

Successfully merging this pull request may close these issues.

4 participants

@rullzer@MorrisJobke@ChristophWurst@juliusknorr