Skip to content

It is very highly recommended to set an object for better filtering - #22857

Merged
MorrisJobke merged 1 commit into
masterfrom
bugfix/activity-490/doc-fixes
Sep 15, 2020
Merged

It is very highly recommended to set an object for better filtering#22857
MorrisJobke merged 1 commit into
masterfrom
bugfix/activity-490/doc-fixes

Conversation

@nickvergessen

@nickvergessennickvergessen commented Sep 15, 2020

Copy link
Copy Markdown
Member

Ref discussion in nextcloud/activity#490

Signed-off-by: Joas Schilling <coding@schilljs.com>
@faily-bot

faily-botBot commented Sep 15, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 33068: failure

mysql5.6-php7.2

Show full log
There were 2 errors:
1) OCA\Files\Tests\BackgroundJob\DeleteOrphanedItemsJobTest::testClearComments
Doctrine\DBAL\Exception\UniqueConstraintViolationException: An exception occurred while executing 'INSERT INTO `oc_filecache` (`storage`, `path`, `path_hash`) VALUES(?, ?, ?)' with params [1337, "apps\/files\/tests\/deleteorphanedtagsjobtest.php", "4cc42159b8d10b8a7295624bae65759f"]:
SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '1337-4cc42159b8d10b8a7295624bae65759f' for key 'fs_storage_path_hash'
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/AbstractMySQLDriver.php:55
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php:169
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php:149
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:1071
/drone/src/lib/private/DB/Connection.php:214
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Query/QueryBuilder.php:209
/drone/src/lib/private/DB/QueryBuilder/QueryBuilder.php:217
/drone/src/apps/files/tests/BackgroundJob/DeleteOrphanedItemsJobTest.php:173
Caused by
Doctrine\DBAL\Driver\PDOException: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '1337-4cc42159b8d10b8a7295624bae65759f' for key 'fs_storage_path_hash'
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php:129
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:1062
/drone/src/lib/private/DB/Connection.php:214
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Query/QueryBuilder.php:209
/drone/src/lib/private/DB/QueryBuilder/QueryBuilder.php:217
/drone/src/apps/files/tests/BackgroundJob/DeleteOrphanedItemsJobTest.php:173
Caused by
PDOException: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '1337-4cc42159b8d10b8a7295624bae65759f' for key 'fs_storage_path_hash'
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php:127
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:1062
/drone/src/lib/private/DB/Connection.php:214
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Query/QueryBuilder.php:209
/drone/src/lib/private/DB/QueryBuilder/QueryBuilder.php:217
/drone/src/apps/files/tests/BackgroundJob/DeleteOrphanedItemsJobTest.php:173
2) OCA\Files\Tests\BackgroundJob\DeleteOrphanedItemsJobTest::testClearCommentReadMarks
Doctrine\DBAL\Exception\UniqueConstraintViolationException: An exception occurred while executing 'INSERT INTO `oc_filecache` (`storage`, `path`, `path_hash`) VALUES(?, ?, ?)' with params [1337, "apps\/files\/tests\/deleteorphanedtagsjobtest.php", "4cc42159b8d10b8a7295624bae65759f"]:
SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '1337-4cc42159b8d10b8a7295624bae65759f' for key 'fs_storage_path_hash'
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/AbstractMySQLDriver.php:55
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php:169
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php:149
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:1071
/drone/src/lib/private/DB/Connection.php:214
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Query/QueryBuilder.php:209
/drone/src/lib/private/DB/QueryBuilder/QueryBuilder.php:217
/drone/src/apps/files/tests/BackgroundJob/DeleteOrphanedItemsJobTest.php:224
Caused by
Doctrine\DBAL\Driver\PDOException: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '1337-4cc42159b8d10b8a7295624bae65759f' for key 'fs_storage_path_hash'
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php:129
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:1062
/drone/src/lib/private/DB/Connection.php:214
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Query/QueryBuilder.php:209
/drone/src/lib/private/DB/QueryBuilder/QueryBuilder.php:217
/drone/src/apps/files/tests/BackgroundJob/DeleteOrphanedItemsJobTest.php:224
Caused by
PDOException: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '1337-4cc42159b8d10b8a7295624bae65759f' for key 'fs_storage_path_hash'
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php:127
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:1062
/drone/src/lib/private/DB/Connection.php:214
/drone/src/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Query/QueryBuilder.php:209
/drone/src/lib/private/DB/QueryBuilder/QueryBuilder.php:217
/drone/src/apps/files/tests/BackgroundJob/DeleteOrphanedItemsJobTest.php:224
--
There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
--
There was 1 failure:
1) OCA\Files\Tests\BackgroundJob\DeleteOrphanedItemsJobTest::testClearUserTagMappings
Failed asserting that actual size 0 matches expected size 1.
/drone/src/apps/files/tests/BackgroundJob/DeleteOrphanedItemsJobTest.php:152

acceptance-header

  • tests/acceptance/features/header.feature:31
Show full log
 Scenario: users from other groups are not seen in the contacts menu when autocompletion is restricted within the same group # /drone/src/tests/acceptance/features/header.feature:31
Given I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I visit the settings page # SettingsMenuContext::iVisitTheSettingsPage()
And I open the "Sharing" section of the "Administration" group # AppNavigationContext::iOpenTheSectionOf()
And I enable restricting username autocompletion to groups # SettingsContext::iEnableRestrictingUsernameAutocompletionToGroups()
And I see that username autocompletion is restricted to groups # SettingsContext::iSeeThatUsernameAutocompletionIsRestrictedToGroups()
When I open the Contacts menu # ContactsMenuContext::iOpenTheContactsMenu()
Then I see that the Contacts menu is shown # ContactsMenuContext::iSeeThatTheContactsMenuIsShown()
And I see that the contact "user0" in the Contacts menu is not shown # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsNotShown()
Failed asserting that true is false.
And I see that the contact "admin" in the Contacts menu is not shown # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsNotShown()

@rullzerrullzer mentioned this pull request Sep 15, 2020
5 tasks
@MorrisJobke
MorrisJobke merged commit 733c0f7 into masterSep 15, 2020
@MorrisJobke
MorrisJobke deleted the bugfix/activity-490/doc-fixes branch September 15, 2020 10:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen@rullzer@MorrisJobke