Skip to content

Fix recommendation design details - #22866

Merged
MorrisJobke merged 3 commits into
masterfrom
fix/recommendations-alt
Sep 16, 2020
Merged

Fix recommendation design details#22866
MorrisJobke merged 3 commits into
masterfrom
fix/recommendations-alt

Conversation

@jancborchardt

Copy link
Copy Markdown
Member

Ref #22864

  • Loading spinner color is off
  • Icons have alternative text, should not have since they are decorative → empty alt=""

Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
@MorrisJobke
MorrisJobke merged commit e392525 into masterSep 16, 2020
@MorrisJobke
MorrisJobke deleted the fix/recommendations-alt branch September 16, 2020 11:41
@MorrisJobkeMorrisJobke mentioned this pull request Sep 16, 2020
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugdesignDesign, UI, UX, etc.feature: recommended apps

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jancborchardt@juliusknorr@skjnldsv@MorrisJobke