Uh oh!
There was an error while loading. Please reload this page.
Shared storage optimizations - #22867
Merged
Merged
Conversation
update checking is already handled by the share source Signed-off-by: Robin Appelman <robin@icewind.nl>
MorrisJobke
commented
Sep 15, 2020
Member
Mind to fix the unit tests and the code style complaints? |
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991force-pushed
the
shared-storage-init-less
branch
from
September 16, 2020 11:49
210726a to
cfde744Compareicewind1991
commented
Sep 16, 2020
MemberAuthor
done |
MorrisJobke
approved these changes
Sep 16, 2020
MorrisJobke
left a comment
Member
There was a problem hiding this comment.
Code looks good, tested and works 👍
rullzer
approved these changes
Sep 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instanceOfStorage('\OCP\Files\IHomeStorage')