Uh oh!
There was an error while loading. Please reload this page.
Fix/unified search papercuts - #22868
Merged
Merged
Conversation
skjnldsv
requested review from
ChristophWurst, MorrisJobke, jancborchardt, juliusknorr, nickvergessen, raimund-schluessler and rullzerSeptember 15, 2020 15:24
This comment has been minimized.
This comment has been minimized.
skjnldsvforce-pushed
the
fix/unified-search-papercuts
branch
from
September 16, 2020 07:45
77b8d4d to
53a4734CompareUh oh!
There was an error while loading. Please reload this page.
This comment has been minimized.
This comment has been minimized.
nickvergessen
approved these changes
Sep 16, 2020
skjnldsv
commented
Sep 16, 2020
MemberAuthor
Thanks for the fix Joas :) |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsvforce-pushed
the
fix/unified-search-papercuts
branch
from
September 18, 2020 08:01
f557645 to
23a9138Compareskjnldsv
commented
Sep 18, 2020
MemberAuthor
skjnldsv
commented
Sep 18, 2020
MemberAuthor
/backport to stable20 |
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 33202: failuremariadb10.1-php7.2Show full logmariadb10.4-php7.3Show full logmysql5.6-php7.2Show full log |
raimund-schluessler
commented
Sep 19, 2020
Member
I know, I am a bit late, but it works very nicely now! Thanks a lot @skjnldsv for taking care. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final remnants of #22092 (comment)
No resultsflashes briefly before a searchAlso makes aria landmarks compliant
