Skip to content

Fix/unified search papercuts - #22868

Merged
rullzer merged 5 commits into
masterfrom
fix/unified-search-papercuts
Sep 18, 2020
Merged

Fix/unified search papercuts#22868
rullzer merged 5 commits into
masterfrom
fix/unified-search-papercuts

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Sep 15, 2020

Copy link
Copy Markdown
Member

Final remnants of #22092 (comment)

  • No results flashes briefly before a search
  • Add loading spinners on unfinished search providers requests
  • Cancel requests on search and on reset

Capture d’écran_2020-09-15_17-15-48
Capture d’écran_2020-09-15_17-16-11


Also makes aria landmarks compliant
Capture d’écran_2020-09-15_17-25-45

@skjnldsvskjnldsv added design Design, UI, UX, etc. 3. to review Waiting for reviews papercut Annoying recurring UX issue with possibly simple fix. feature: search labels Sep 15, 2020
@skjnldsvskjnldsv added this to the Nextcloud 20 milestone Sep 15, 2020
@skjnldsvskjnldsv self-assigned this Sep 15, 2020
@skjnldsv

This comment has been minimized.

Comment threadcore/src/views/UnifiedSearch.vue
@nickvergessen

This comment has been minimized.

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

TypeError: n.sent.data is undefined
n UnifiedSearch.vue:469

I get this when trying to load more results of e.g. Talk messages

Thanks for the fix Joas :)

@skjnldsvskjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Sep 16, 2020
@MorrisJobkeMorrisJobke mentioned this pull request Sep 16, 2020
5 tasks
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsvskjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 18, 2020
@skjnldsv
skjnldsvforce-pushed the fix/unified-search-papercuts branch from f557645 to 23a9138CompareSeptember 18, 2020 08:01
@skjnldsv

Copy link
Copy Markdown
MemberAuthor

Done @MorrisJobke@raimund-schluessler@rullzer

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/backport to stable20

@faily-bot

faily-botBot commented Sep 18, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 33202: failure

mariadb10.1-php7.2

Show full log
There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
--
There was 1 failure:
1) OCA\Files_Versions\Tests\VersioningTest::testRestoreMovedShare
File content has not changed
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'version 2'
+'version 1'
/drone/src/apps/files_versions/tests/VersioningTest.php:729

mariadb10.4-php7.3

Show full log
There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
--
There was 1 failure:
1) Test\Share20\DefaultShareProviderTest::testDeleteUser with data set #3 (0, 'a', 'b', 'c', 'd', false)
Failed asserting that actual size 0 matches expected size 1.
/drone/src/tests/lib/Share20/DefaultShareProviderTest.php:2255

mysql5.6-php7.2

Show full log
There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
--
There was 1 failure:
1) OCA\Files_Sharing\Tests\ExpireSharesJobTest::testExpireLinkShare with data set #6 (true, 'P1M', false, true)
Failed asserting that actual size 1 matches expected size 0.
/drone/src/apps/files_sharing/tests/ExpireSharesJobTest.php:186

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets do this 🚀

@rullzer
rullzer merged commit bd9af41 into masterSep 18, 2020
@rullzer
rullzer deleted the fix/unified-search-papercuts branch September 18, 2020 09:34
@raimund-schluessler

Copy link
Copy Markdown
Member

Done @MorrisJobke@raimund-schluessler@rullzer

I know, I am a bit late, but it works very nicely now! Thanks a lot @skjnldsv for taking care.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugdesignDesign, UI, UX, etc.feature: searchpapercutAnnoying recurring UX issue with possibly simple fix.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv@nickvergessen@raimund-schluessler@rullzer