Uh oh!
There was an error while loading. Please reload this page.
improve handling of files we can't access in the scanner - #22943
Merged
Conversation
icewind1991
commented
Sep 18, 2020
MemberAuthor
/backport to stable20 |
icewind1991
commented
Sep 18, 2020
MemberAuthor
/backport to stable19 |
juliusknorr
approved these changes
Sep 22, 2020
rullzer
commented
Oct 4, 2020
Member
static code analysis is not happy: https://github.com/nextcloud/server/pull/22943/checks?check_run_id=1134675980 |
PVince81
commented
Mar 17, 2021
Member
@icewind1991 rebase and fix psalm ? |
icewind1991force-pushed
the
scanner-no-access-handling
branch
from
March 24, 2021 16:05
6039742 to
7565b10Compareicewind1991
commented
Mar 24, 2021
MemberAuthor
rebasing made psalm happy |
blizzz
commented
Jun 2, 2021
Member
@icewind1991 could you check the tests? |
blizzz
commented
Jun 16, 2021
Member
CI unhappy, 35 errors in samba tests |
This comment has been minimized.
This comment has been minimized.
nextcloud-commandforce-pushed
the
scanner-no-access-handling
branch
from
October 13, 2021 10:23
7565b10 to
986a242Compareskjnldsv
commented
Oct 22, 2021
Member
Samba tests failing |
skjnldsv
commented
Oct 22, 2021
Member
/rebase |
nextcloud-commandforce-pushed
the
scanner-no-access-handling
branch
from
October 22, 2021 11:04
986a242 to
ebab4f8Compareicewind1991force-pushed
the
scanner-no-access-handling
branch
from
April 4, 2023 15:36
ebab4f8 to
2364d1cCompareinstead of erroring, remove the items from the cache. this situation can be triggered if a user has access to a file but looses it afterwards Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991force-pushed
the
scanner-no-access-handling
branch
from
April 5, 2023 12:45
2364d1c to
b1f352cCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instead of erroring, remove the items from the cache.
this situation can be triggered if a user has access to a file but looses it afterwards
Signed-off-by: Robin Appelman robin@icewind.nl