Bump jquery from 2.2.4 to 3.5.0

[dependabot]

Bumps jquery from 2.2.4 to 3.5.0.

Release notes

Sourced from jquery's releases.

jQuery 3.5.0 Released!

See the blog post: https://blog.jquery.com/2020/04/10/jquery-3-5-0-released/ and the upgrade guide: https://jquery.com/upgrade-guide/3.5/

NOTE: Despite being a minor release, this update includes a breaking change that we had to make to fix a security issue ( CVE-2020-11022). Please follow the blog post & the upgrade guide for more details.

Commits

• 7a0a850 3.5.0
• 8570a08 Release: Update AUTHORS.txt
• da3dd85 Ajax: Do not execute scripts for unsuccessful HTTP responses
• 065143c Ajax: Overwrite s.contentType with content-type header value, if any
• 1a4f10d Tests: Blacklist one focusin test in IE
• 9e15d6b Event: Use only one focusin/out handler per matching window & document
• 966a709 Manipulation: Skip the select wrapper for <option> outside of IE 9
• 1d61fd9 Manipulation: Make jQuery.htmlPrefilter an identity function
• 04bf577 Selector: Update Sizzle from 2.3.4 to 2.3.5
• 7506c9c Build: Resolve Travis config warnings
• Additional commits viewable in compare view

Maintainer changes

This version was pushed to npm by mgol, a new releaser for jquery since your current version.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

[juliusknorr]

jQuery is deprecated: The global jQuery is deprecated. It will be updated to v3.x in Nextcloud 21. In later versions of Nextcloud it might be removed completely. Please ship your own.

Did a quick check, clicked around a bit and didn't found any huge issue yet. LDAP wizard still seems to work. So I'd say we get this in early for 21 now :)

[juliusknorr]

Failures might be related, need to check again.

[ChristophWurst]

server/core/src/globals.js

Line 103 in 54f4ede

setDeprecatedProp(['$','jQuery'],()=>$,'The global jQuery is deprecated. It will be updated to v3.x in Nextcloud 21. In later versions of Nextcloud it might be removed completely. Please ship your own.')

Let's do this 🚀

[wenz]

Please make sure to update to 3.5.1, not to 3.5.0 (which introduced a regression, cf. https://blog.jquery.com/2020/05/04/jquery-3-5-1-released-fixing-a-regression/)

[rullzer]

@dependabot-bot recreate

[rullzer]

mmm why is dependabot not bumping it to 3.5.1 ?

[ChristophWurst]

@dependabot rebase

[juliusknorr]

/compile amend /

[juliusknorr]

Manually bumped to 3.5.1 now, not sure why dependabot was not picking that one up. Let's see if CI is also happy with that. I couldn't see any major breaking with 3.5.1 as well

[ChristophWurst]

not sure why dependabot was not picking that one up

I think because of the security bump. I thinks we're fixing the v2.2 flaws with 3.5.

[skjnldsv]

@dependabot recreate

[skjnldsv]

/compile amend /

[skjnldsv]

Manually bumped to 3.5.1 now, not sure why dependabot was not picking that one up. Let's see if CI is also happy with that. I couldn't see any major breaking with 3.5.1 as well

I think because of the security bump. I thinks we're fixing the v2.2 flaws with 3.5.

No it's because the version is fixed in the package.json
"jquery": "3.5.0" instead of "jquery": "^3.5.0"

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 35054: failure

jsunit

Show full log

PhantomJS 2.1.1 (Linux 0.0.0) WARN: 'No OC found'
PhantomJS 2.1.1 (Linux 0.0.0) LOG: 'JQMIGRATE: Migrate is installed, version 1.4.1'
PhantomJS 2.1.1 (Linux 0.0.0) WARN: 'jQuery is deprecated: The global jQuery is deprecated. It will be updated to v3.x in Nextcloud 21. In later versions of Nextcloud it might be removed completely. Please ship your own.'
PhantomJS 2.1.1 (Linux 0.0.0) WARN: '$ is deprecated: The global jQuery is deprecated. It will be updated to v3.x in Nextcloud 21. In later versions of Nextcloud it might be removed completely. Please ship your own.'
PhantomJS 2.1.1 (Linux 0.0.0) WARN: 'Handlebars is deprecated: please ship your own, this will be removed in Nextcloud 20'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Files.Settings initialized'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Files.Sidebar initialized'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Sharing.ShareSearch initialized'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Sharing.ExternalLinkActions initialized'
PhantomJS 2.1.1 (Linux 0.0.0) Contacts menu shows only one entry's action menu at a time FAILED
Expected '' to be 'block'.
core/js/tests/specs/contactsmenuSpec.js:246:76
apps/files_sharing/js/dist/files_sharing_tab.js:1:17365786
apps/files_sharing/js/dist/files_sharing_tab.js:1:17366236
A@apps/files_sharing/js/dist/files_sharing_tab.js:1:11581872
Expected '' to be 'block'.
core/js/tests/specs/contactsmenuSpec.js:252:76
apps/files_sharing/js/dist/files_sharing_tab.js:1:17365786
apps/files_sharing/js/dist/files_sharing_tab.js:1:17366236
A@apps/files_sharing/js/dist/files_sharing_tab.js:1:11581872
PhantomJS 2.1.1 (Linux 0.0.0) jquery.contactsMenu tests send requests to the server and render load a topaction only FAILED
Expected '<div class="menu popovermenu menu-left contactsmenu-popover loaded" style="display: block;"><ul><li><a><span class="icon-loading-small"></span></a></li></ul></div>' to equal '<div class="menu popovermenu menu-left contactsmenu-popover loaded" style="display: block;"><ul><li class="hidden"><a><span class="icon-loading-small"></span></a></li><li><a href="mailto:bar%40baz.wtf"><img src="foo.svg"><span>bar@baz.wtf</span></a></li></ul></div>'.
core/js/tests/specs/jquery.contactsmenuSpec.js:123:70
PhantomJS 2.1.1 (Linux 0.0.0) jquery.contactsMenu tests send requests to the server and render load topaction and more actions FAILED
Expected '<div class="menu popovermenu menu-left contactsmenu-popover loaded" style="display: block;"><ul><li><a><span class="icon-loading-small"></span></a></li></ul></div>' to equal '<div class="menu popovermenu menu-left contactsmenu-popover loaded" style="display: block;"><ul><li class="hidden"><a><span class="icon-loading-small"></span></a></li><li><a href="mailto:bar%40baz.wtf"><img src="foo.svg"><span>bar@baz.wtf</span></a></li><li><a href="http://localhost/index.php/apps/contacts"><img src="details.svg"><span>Details</span></a></li></ul></div>'.
core/js/tests/specs/jquery.contactsmenuSpec.js:150:70
PhantomJS 2.1.1 (Linux 0.0.0) jquery.contactsMenu tests send requests to the server and render load no actions FAILED
Expected '<div class="menu popovermenu menu-left contactsmenu-popover loaded" style="display: block;"><ul><li><a><span class="icon-loading-small"></span></a></li></ul></div>' to equal '<div class="menu popovermenu menu-left contactsmenu-popover loaded" style="display: block;"><ul><li class="hidden"><a><span class="icon-loading-small"></span></a></li><li><a href="#"><span>No action available</span></a></li></ul></div>'.
core/js/tests/specs/jquery.contactsmenuSpec.js:170:70
PhantomJS 2.1.1 (Linux 0.0.0) jquery.contactsMenu tests send requests to the server and render should throw an error FAILED
Expected '<div class="menu popovermenu menu-left contactsmenu-popover loaded" style="display: block;"><ul><li><a><span class="icon-loading-small"></span></a></li></ul></div>' to equal '<div class="menu popovermenu menu-left contactsmenu-popover loaded" style="display: block;"><ul><li class="hidden"><a><span class="icon-loading-small"></span></a></li><li><a href="#"><span>Error fetching contact actions</span></a></li></ul></div>'.
core/js/tests/specs/jquery.contactsmenuSpec.js:185:70
PhantomJS 2.1.1 (Linux 0.0.0) jquery.contactsMenu tests send requests to the server and render should handle 404 FAILED
Expected '<div class="menu popovermenu menu-left contactsmenu-popover loaded" style="display: block;"><ul><li><a><span class="icon-loading-small"></span></a></li></ul></div>' to equal '<div class="menu popovermenu menu-left contactsmenu-popover loaded" style="display: block;"><ul><li class="hidden"><a><span class="icon-loading-small"></span></a></li><li><a href="#"><span>No action available</span></a></li></ul></div>'.
core/js/tests/specs/jquery.contactsmenuSpec.js:200:70
PhantomJS 2.1.1 (Linux 0.0.0) OC.L10N tests async loading of translations loads bundle for given app and calls callback FAILED
Expected false to equal true.
core/js/tests/specs/l10nSpec.js:134:43
Expected false to equal true.
core/js/tests/specs/l10nSpec.js:135:42
Expected 'Hello world!' to equal '你好世界!'.
core/js/tests/specs/l10nSpec.js:136:47
PhantomJS 2.1.1 (Linux 0.0.0) OC.L10N tests async loading of translations calls callback if translation already available FAILED
Expected false to equal true.
core/js/tests/specs/l10nSpec.js:147:43
Expected false to equal true.
core/js/tests/specs/l10nSpec.js:148:42
PhantomJS 2.1.1 (Linux 0.0.0) OC.L10N tests async loading of translations calls callback if locale is en FAILED
Expected false to equal true.
core/js/tests/specs/l10nSpec.js:156:43
Expected false to equal true.
core/js/tests/specs/l10nSpec.js:157:42
PhantomJS 2.1.1 (Linux 0.0.0) Backbone Webdav extension collections makes a POST request to create model into collection FAILED
Expected undefined to equal '123'.
core/js/tests/specs/oc-backbone-webdavSpec.js:107:28
PhantomJS 2.1.1 (Linux 0.0.0) Backbone Webdav extension collections uses PROPFIND to retrieve collection FAILED
Expected 0 to equal 2.
core/js/tests/specs/oc-backbone-webdavSpec.js:167:37
TypeError: undefined is not an object (evaluating 'model.id') in core/js/tests/specs/oc-backbone-webdavSpec.js (line 170)
core/js/tests/specs/oc-backbone-webdavSpec.js:170:16
PhantomJS 2.1.1 (Linux 0.0.0) Backbone Webdav extension collections calls error handler if error status in PROPFIND response FAILED
Expected false to equal true.
testMethodError@core/js/tests/specs/oc-backbone-webdavSpec.js:195:40
core/js/tests/specs/oc-backbone-webdavSpec.js:199:19
PhantomJS 2.1.1 (Linux 0.0.0) Backbone Webdav extension collections calls error handler if error status in POST response FAILED
Expected false to equal true.
testMethodError@core/js/tests/specs/oc-backbone-webdavSpec.js:195:40
core/js/tests/specs/oc-backbone-webdavSpec.js:208:19
PhantomJS 2.1.1 (Linux 0.0.0) Backbone Webdav extension models uses PROPFIND to fetch single model FAILED
Expected undefined to equal 'Hello'.
core/js/tests/specs/oc-backbone-webdavSpec.js:323:42
Expected undefined to equal 'World'.
core/js/tests/specs/oc-backbone-webdavSpec.js:324:41
Expected undefined to equal 35.
core/js/tests/specs/oc-backbone-webdavSpec.js:325:36
Expected undefined to equal true.
core/js/tests/specs/oc-backbone-webdavSpec.js:326:40
PhantomJS 2.1.1 (Linux 0.0.0) Backbone Webdav extension models calls error handler if error status in PROPFIND response FAILED
Expected false to equal true.
testMethodError@core/js/tests/specs/oc-backbone-webdavSpec.js:365:40
core/js/tests/specs/oc-backbone-webdavSpec.js:369:19
PhantomJS 2.1.1 (Linux 0.0.0) Backbone Webdav extension models calls error handler if error status in PROPPATCH response FAILED
Expected false to equal true.
testMethodError@core/js/tests/specs/oc-backbone-webdavSpec.js:365:40
core/js/tests/specs/oc-backbone-webdavSpec.js:378:19
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FavoritesFileList tests loading file list render files FAILED
Expected 0 to equal 1.
apps/files/tests/js/favoritesfilelistspec.js:82:32
Expected undefined to equal '7'.
apps/files/tests/js/favoritesfilelistspec.js:83:39
Expected undefined to equal 'file'.
apps/files/tests/js/favoritesfilelistspec.js:84:41
Expected undefined to equal 'test.txt'.
apps/files/tests/js/favoritesfilelistspec.js:85:41
Expected undefined to equal '/somedir'.
apps/files/tests/js/favoritesfilelistspec.js:86:41
Expected undefined to equal '123'.
apps/files/tests/js/favoritesfilelistspec.js:87:41
Expected NaN to equal 31.
apps/files/tests/js/favoritesfilelistspec.js:89:13
Expected undefined to equal 'text/plain'.
apps/files/tests/js/favoritesfilelistspec.js:90:41
Expected undefined to equal '11111000'.
apps/files/tests/js/favoritesfilelistspec.js:91:42
Expected undefined to equal 'http://localhost/remote.php/webdav/somedir/test.txt'.
apps/files/tests/js/favoritesfilelistspec.js:92:51
Expected '' to equal 'test.txt'.
apps/files/tests/js/favoritesfilelistspec.js:96:55
PhantomJS 2.1.1 (Linux 0.0.0) OC.Upload tests Upload conflicts shows conflict dialog when no client side conflict FAILED
Expected false to equal true.
apps/files/tests/js/fileUploadSpec.js:211:49
PhantomJS 2.1.1 (Linux 0.0.0) OC.Upload tests Upload conflicts autorenames file when choosing replace in conflict mode FAILED
Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests Deleting files calls delete.php, removes the deleted entries and updates summary FAILED
Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests Deleting files shows busy state on files to be deleted FAILED
Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests Deleting files shows busy state on all files when deleting all FAILED
Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests Deleting files updates summary when deleting last file FAILED
Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests Deleting files bring back deleted item when delete call failed FAILED
Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests Deleting files remove file from list if delete call returned 404 not found FAILED
Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests Moving files Moves single file to target folder FAILED
Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests Moving files Moves list of files to target folder FAILED
Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests Moving files Shows notification if a file could not be moved FAILED
Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests Moving files Restores thumbnail if a file could not be moved FAILED
Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests Copying files Copies single file to target folder FAILED
Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests Copying files Copies list of files to target folder FAILED
Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests Copying files Shows notification if a file could not be copied FAILED
Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests Copying files Restores thumbnail if a file could not be copied FAILED
Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests loading file list fetches file list from server and renders it when reload() is called FAILED
Expected 0 to equal 4.
apps/files/tests/js/filelistSpec.js:1685:44
Expected 0 to equal 1.
apps/files/tests/js/filelistSpec.js:1686:57
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests loading file list switches to root dir when current directory does not exist FAILED
Expected '/unexist' to equal '/'.
apps/files/tests/js/filelistSpec.js:1730:50
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests loading file list switches to root dir when current directory returns 400 FAILED
Expected '/unexist' to equal '/'.
apps/files/tests/js/filelistSpec.js:1735:50
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests loading file list switches to root dir when current directory returns 405 FAILED
Expected '/unexist' to equal '/'.
apps/files/tests/js/filelistSpec.js:1740:50
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests loading file list switches to root dir when current directory is forbidden FAILED
Expected '/unexist' to equal '/'.
apps/files/tests/js/filelistSpec.js:1745:50
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests loading file list switches to root dir when current directory is unavailable FAILED
Expected '/unexist' to equal '/'.
apps/files/tests/js/filelistSpec.js:1750:50
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests loading file list shows mask before loading file list then hides it at the end FAILED
Expected false to equal true.
apps/files/tests/js/filelistSpec.js:1760:43
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests loading file list triggers "afterChangeDirectory" event with fileid after changing directory FAILED
Expected false to equal true.
apps/files/tests/js/filelistSpec.js:1777:38
TypeError: null is not an object (evaluating 'handler.getCall(0).args') in apps/files/tests/js/filelistSpec.js (line 1778)
apps/files/tests/js/filelistSpec.js:1778:29
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests breadcrumb events dropping files on breadcrumb calls move operation FAILED
Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests File selection Actions Delete Deletes selected files when "Delete" clicked FAILED
Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests File selection Actions Delete Deletes all files when all selected when "Delete" clicked FAILED
Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests create file creates file with given name and adds it to the list FAILED
Expected 0 to equal 1.
apps/files/tests/js/filelistSpec.js:2839:30
Expected undefined to equal 'text/plain'.
apps/files/tests/js/filelistSpec.js:2840:41
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests create folder creates folder with given name and adds it to the list FAILED
Expected 0 to equal 1.
apps/files/tests/js/filelistSpec.js:2885:30
Expected undefined to equal 'httpd/unix-directory'.
apps/files/tests/js/filelistSpec.js:2886:41
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests addAndFetchFileInfo adds file data to list when fetching is done FAILED
Expected undefined to equal '100'.
apps/files/tests/js/filelistSpec.js:2920:73
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests addAndFetchFileInfo replaces file data to list when fetching is done FAILED
Expected '95' to equal '100'.
apps/files/tests/js/filelistSpec.js:2932:73
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests addAndFetchFileInfo resolves promise with file data when fetching is done FAILED
Expected 'pending' to equal 'resolved'.
apps/files/tests/js/filelistSpec.js:2940:35
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests file upload after upload highlights all uploaded files after all fetches are done FAILED
Expected false to equal true.
apps/files/tests/js/filelistSpec.js:3182:45
TypeError: null is not an object (evaluating 'highlightStub.getCall(0).args') in apps/files/tests/js/filelistSpec.js (line 3183)
apps/files/tests/js/filelistSpec.js:3183:36
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests file upload after upload queries storage stats after all fetches are done FAILED
Expected false to equal true.
apps/files/tests/js/filelistSpec.js:3200:40
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests Handling errors redirects to root folder in case of forbidden access FAILED
Expected '/subdir' to equal '/'.
apps/files/tests/js/filelistSpec.js:3225:50
Expected false to equal true.
apps/files/tests/js/filelistSpec.js:3226:53
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests Handling errors redirects to root folder and shows notification in case of internal server error FAILED
Expected '/subdir' to equal '/'.
apps/files/tests/js/filelistSpec.js:3232:50
Expected false to equal true.
apps/files/tests/js/filelistSpec.js:3233:53
Expected false to equal true.
apps/files/tests/js/filelistSpec.js:3234:47
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests Handling errors redirects to root folder and shows notification in case of storage not available FAILED
Expected '/subdir' to equal '/'.
apps/files/tests/js/filelistSpec.js:3240:50
Expected false to equal true.
apps/files/tests/js/filelistSpec.js:3241:53
Expected false to equal true.
apps/files/tests/js/filelistSpec.js:3242:47
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.MainFileInfoDetailView tests events triggers default action when clicking on the thumbnail FAILED
Expected false to equal true.
apps/files/tests/js/mainfileinfodetailviewSpec.js:259:44
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.TagsPlugin tests Applying tags through FileActionsMenu sends request to server and updates icon FAILED
Expected undefined to equal 'true'.
apps/files/tests/js/tagspluginspec.js:100:45
Expected [ 'tag1', 'tag2' ] to equal [ 'tag1', 'tag2', 'tag3', '_$!<Favorite>!$_' ].
apps/files/tests/js/tagspluginspec.js:101:52
Expected [ 'tag1', 'tag2' ] to equal [ 'tag1', 'tag2', 'tag3', '_$!<Favorite>!$_' ].
apps/files/tests/js/tagspluginspec.js:102:42
Expected true to equal false.
apps/files/tests/js/tagspluginspec.js:103:69
Expected false to equal true.
apps/files/tests/js/tagspluginspec.js:104:72
Expected Object({ tags: [ 'tag1', 'tag2', '_$!<Favorite>!$_' ] }) to equal Object({ tags: [ 'tag1', 'tag2', 'tag3' ] }).
apps/files/tests/js/tagspluginspec.js:115:51
Expected [ 'tag1', 'tag2' ] to equal [ 'tag1', 'tag2', 'tag3' ].
apps/files/tests/js/tagspluginspec.js:127:52
Expected [ 'tag1', 'tag2' ] to equal [ 'tag1', 'tag2', 'tag3' ].
apps/files/tests/js/tagspluginspec.js:128:42
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Versions.VersionModel reverting tells the server to revert when calling the revert method FAILED
Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
PhantomJS 2.1.1 (Linux 0.0.0) OCA.SystemTags.FileList tests loading results render files FAILED
Expected 0 to equal 4.
apps/systemtags/tests/js/systemtagsfilelistSpec.js:223:56
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Sharing.Util tests Share action icon shows simple share text with share icon FAILED
Expected 'Share
Shared' to equal 'Shared'.
apps/files_sharing/tests/js/shareSpec.js:106:55
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Sharing.Util tests Share action icon shows simple share text with share icon when shared to a room FAILED
Expected 'Share
Shared' to equal 'Shared'.
apps/files_sharing/tests/js/shareSpec.js:126:55
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Sharing.Util tests Share action icon shows simple share text with public icon when shared with link FAILED
Expected 'Share
Shared' to equal 'Shared'.
apps/files_sharing/tests/js/shareSpec.js:147:55
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Sharing.Util tests Share action icon shows recipients when recipients are available FAILED
Expected 'Share
Shared with User One Shared with User Two' to equal 'Shared with User One Shared with User Two'.
apps/files_sharing/tests/js/shareSpec.js:200:41
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files_External.FileList tests loading file list for external storages render storage list FAILED
Expected 0 to equal 2.
apps/files_external/tests/js/mountsfilelistSpec.js:116:32
Expected undefined to equal 'dir'.
apps/files_external/tests/js/mountsfilelistSpec.js:120:41
Expected undefined to equal 'sftp mount'.
apps/files_external/tests/js/mountsfilelistSpec.js:121:41
Expected undefined to equal '/another mount points'.
apps/files_external/tests/js/mountsfilelistSpec.js:122:41
Expected undefined to equal '1'.
apps/files_external/tests/js/mountsfilelistSpec.js:124:48
Expected undefined to equal 'http://localhost/index.php/apps/files?dir=/another%20mount%20points/sftp%20mount'.
apps/files_external/tests/js/mountsfilelistSpec.js:125:51
Expected '' to equal 'sftp mount'.
apps/files_external/tests/js/mountsfilelistSpec.js:130:55
Expected '' to equal 'System'.
apps/files_external/tests/js/mountsfilelistSpec.js:131:66
Expected '' to equal 'SFTP'.
apps/files_external/tests/js/mountsfilelistSpec.js:132:61
Expected undefined to equal 'dir'.
apps/files_external/tests/js/mountsfilelistSpec.js:136:41
Expected undefined to equal 'smb mount'.
apps/files_external/tests/js/mountsfilelistSpec.js:137:41
Expected undefined to equal '/mount points'.
apps/files_external/tests/js/mountsfilelistSpec.js:138:41
Expected undefined to equal '9'.
apps/files_external/tests/js/mountsfilelistSpec.js:140:48
Expected undefined to equal 'http://localhost/index.php/apps/files?dir=/mount%20points/smb%20mount'.
apps/files_external/tests/js/mountsfilelistSpec.js:141:51
Expected '' to equal 'smb mount'.
apps/files_external/tests/js/mountsfilelistSpec.js:146:55
Expected '' to equal 'Personal'.
apps/files_external/tests/js/mountsfilelistSpec.js:147:66
Expected '' to equal 'SMB'.
apps/files_external/tests/js/mountsfilelistSpec.js:148:61
PhantomJS 2.1.1 (Linux 0.0.0): Executed 812 of 815 (63 FAILED) (skipped 3) (1 min 45.794 secs / 1 min 45.011 secs)

acceptance-app-files-sharing

• tests/acceptance/features/app-files-sharing.feature:3
• tests/acceptance/features/app-files-sharing.feature:23
• tests/acceptance/features/app-files-sharing.feature:86
• tests/acceptance/features/app-files-sharing.feature:113
• tests/acceptance/features/app-files-sharing.feature:298

Show full log

 Scenario: share a file with another user # /drone/src/tests/acceptance/features/app-files-sharing.feature:3
Given I act as John # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I act as Jane # ActorContext::iActAs()
And I am logged in # LoginPageContext::iAmLoggedIn()
And I act as John # ActorContext::iActAs()
And I rename "welcome.txt" to "farewell.txt" # FileListContext::iRenameTo()
And I see that the file list contains a file named "farewell.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
When I share "farewell.txt" with "user0" # FilesAppSharingContext::iShareWith()
│ Share action for file farewell.txt in file list could not be clicked
│ Exception message: Element is not currently visible and so may not be interacted with
│ Build info: version: '2.53.1', revision: 'a36b8b1', time: '2016-06-30 17:37:03'
│ System info: host: 'fda856cce78b', ip: '192.168.96.2', os.name: 'Linux', os.arch: 'amd64', os.version: '4.15.0-76-generic', java.version: '1.8.0_91'
│ Driver info: driver.version: unknown
│ Trying again
│ Share action for file farewell.txt in file list visibility could not be got
│ Exception message: Element not found with xpath, (((//html//*[starts-with(@id, 'app-content-') and not(contains(concat(' ', normalize-space(@class), ' '), ' hidden '))])[1]//*[@id = 'fileList']//span[contains(concat(' ', normalize-space(@class), ' '), ' nametext ') and normalize-space() = 'farewell.txt']/ancestor::tr)[1]/descendant-or-self::*[@class and contains(concat(' ', normalize-space(@class), ' '), ' action-share ')])[1]
│ │ Unable to locate element: {"method":"xpath","selector":"(((//html//*[starts-with(@id, 'app-content-') and not(contains(concat(' ', normalize-space(@class), ' '), ' hidden '))])[1]//*[@id = 'fileList']//span[contains(concat(' ', normalize-space(@class), ' '), ' nametext ') and normalize-space() = 'farewell.txt']/ancestor::tr)[1]/descendant-or-self::*[@class and contains(concat(' ', normalize-space(@class), ' '), ' action-share ')])[1]"}
│ For documentation on this error, please visit: http://seleniumhq.org/exceptions/no_such_element.html
│ Build info: version: '2.53.1', revision: 'a36b8b1', time: '2016-06-30 17:37:03'
│ System info: host: 'fda856cce78b', ip: '192.168.96.2', os.name: 'Linux', os.arch: 'amd64', os.version: '4.15.0-76-generic', java.version: '1.8.0_91'
│ Driver info: driver.version: unknown
│ Trying again
│ Row for file farewell.txt in file list could not be found after 100 seconds
Share action for file farewell.txt in file list could not be found after 100 seconds (NoSuchElementException)
And I see that the file is shared with "user0" # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
And I act as Jane # ActorContext::iActAs()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
Then I see that the file list contains a file named "farewell.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
And I open the details view for "farewell.txt" # FileListContext::iOpenTheDetailsViewFor()
And I see that the details view is open # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
And I open the "Sharing" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
And I see that the "Sharing" tab in the details view is eventually loaded # FilesAppContext::iSeeThatTheTabInTheDetailsViewIsEventuallyLoaded()
And I see that the file is shared with me by "admin" # FilesAppSharingContext::iSeeThatTheFileIsSharedWithMeBy()
Scenario: share a file with another user that needs to accept shares # /drone/src/tests/acceptance/features/app-files-sharing.feature:23
Given I act as John # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I act as Jane # ActorContext::iActAs()
And I am logged in # LoginPageContext::iAmLoggedIn()
And I visit the settings page # SettingsMenuContext::iVisitTheSettingsPage()
And I open the "Sharing" section # AppNavigationContext::iOpenTheSection()
And I disable accepting the shares by default # SettingsContext::iDisableAcceptingTheSharesByDefault()
And I see that shares are not accepted by default # SettingsContext::iSeeThatSharesAreNotAcceptedByDefault()
And I act as John # ActorContext::iActAs()
And I rename "welcome.txt" to "farewell.txt" # FileListContext::iRenameTo()
And I see that the file list contains a file named "farewell.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
When I share "farewell.txt" with "user0" # FilesAppSharingContext::iShareWith()
Row for file farewell.txt in file list could not be found after 100 seconds
Share action for file farewell.txt in file list could not be found after 100 seconds (NoSuchElementException)
And I see that the file is shared with "user0" # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
And I act as Jane # ActorContext::iActAs()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
And I see that the file list does not contain a file named "farewell.txt" # FileListContext::iSeeThatTheFileListDoesNotContainAFileNamed()
And I accept the share for "/farewell.txt" in the notifications # NotificationsContext::iAcceptTheShareForInTheNotifications()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
Then I see that the file list contains a file named "farewell.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
And I open the details view for "farewell.txt" # FileListContext::iOpenTheDetailsViewFor()
And I see that the details view is open # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
And I open the "Sharing" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
And I see that the "Sharing" tab in the details view is eventually loaded # FilesAppContext::iSeeThatTheTabInTheDetailsViewIsEventuallyLoaded()
And I see that the file is shared with me by "admin" # FilesAppSharingContext::iSeeThatTheFileIsSharedWithMeBy()
Scenario: reshare a file with another user # /drone/src/tests/acceptance/features/app-files-sharing.feature:86
Given I act as John # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I act as Jane # ActorContext::iActAs()
And I am logged in # LoginPageContext::iAmLoggedIn()
And I act as Jim # ActorContext::iActAs()
And I am logged in as "user1" # LoginPageContext::iAmLoggedInAs()
And I act as John # ActorContext::iActAs()
And I rename "welcome.txt" to "farewell.txt" # FileListContext::iRenameTo()
And I see that the file list contains a file named "farewell.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
And I share "farewell.txt" with "user0" # FilesAppSharingContext::iShareWith()
│ Share action for file farewell.txt in file list could not be clicked
│ Exception message: Element is no longer attached to the DOM
│ For documentation on this error, please visit: http://seleniumhq.org/exceptions/stale_element_reference.html
│ Build info: version: '2.53.1', revision: 'a36b8b1', time: '2016-06-30 17:37:03'
│ System info: host: 'fda856cce78b', ip: '192.168.96.2', os.name: 'Linux', os.arch: 'amd64', os.version: '4.15.0-76-generic', java.version: '1.8.0_91'
│ Driver info: driver.version: unknown
│ Trying again
│ Row for file farewell.txt in file list could not be found after 100 seconds
Share action for file farewell.txt in file list could not be found after 100 seconds (NoSuchElementException)
And I see that the file is shared with "user0" # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
And I act as Jane # ActorContext::iActAs()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
When I share "farewell.txt" with "user1" # FilesAppSharingContext::iShareWith()
And I see that the file is shared with "user1" # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
And I act as Jim # ActorContext::iActAs()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
Then I see that the file list contains a file named "farewell.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
And I open the details view for "farewell.txt" # FileListContext::iOpenTheDetailsViewFor()
And I see that the details view is open # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
And I open the "Sharing" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
And I see that the "Sharing" tab in the details view is eventually loaded # FilesAppContext::iSeeThatTheTabInTheDetailsViewIsEventuallyLoaded()
And I see that the file is shared with me by "user0" # FilesAppSharingContext::iSeeThatTheFileIsSharedWithMeBy()
Scenario: owner sees reshares with other users # /drone/src/tests/acceptance/features/app-files-sharing.feature:113
Given I act as John # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I act as Jane # ActorContext::iActAs()
And I am logged in # LoginPageContext::iAmLoggedIn()
And I act as John # ActorContext::iActAs()
And I rename "welcome.txt" to "farewell.txt" # FileListContext::iRenameTo()
And I see that the file list contains a file named "farewell.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
And I share "farewell.txt" with "user0" # FilesAppSharingContext::iShareWith()
│ Share action for file farewell.txt in file list could not be clicked
│ Exception message: Element is no longer attached to the DOM
│ For documentation on this error, please visit: http://seleniumhq.org/exceptions/stale_element_reference.html
│ Build info: version: '2.53.1', revision: 'a36b8b1', time: '2016-06-30 17:37:03'
│ System info: host: 'fda856cce78b', ip: '192.168.96.2', os.name: 'Linux', os.arch: 'amd64', os.version: '4.15.0-76-generic', java.version: '1.8.0_91'
│ Driver info: driver.version: unknown
│ Trying again
│ Row for file farewell.txt in file list could not be found after 100 seconds
Share action for file farewell.txt in file list could not be found after 100 seconds (NoSuchElementException)
And I see that the file is shared with "user0" # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
And I act as Jane # ActorContext::iActAs()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
And I share "farewell.txt" with "user1" # FilesAppSharingContext::iShareWith()
And I see that the file is shared with "user1" # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
When I act as John # ActorContext::iActAs()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
And I open the details view for "farewell.txt" # FileListContext::iOpenTheDetailsViewFor()
And I see that the details view is open # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
And I open the "Sharing" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
And I see that the "Sharing" tab in the details view is eventually loaded # FilesAppContext::iSeeThatTheTabInTheDetailsViewIsEventuallyLoaded()
Then I see that the file is shared with "user0" # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
And I see that the file is shared with "user1" # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
Scenario: sharee can not reshare a file with edit permission if the sharer disables it # /drone/src/tests/acceptance/features/app-files-sharing.feature:298
Given I act as John # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I act as Jane # ActorContext::iActAs()
And I am logged in # LoginPageContext::iAmLoggedIn()
And I act as John # ActorContext::iActAs()
And I rename "welcome.txt" to "farewell.txt" # FileListContext::iRenameTo()
And I see that the file list contains a file named "farewell.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
And I share "farewell.txt" with "user0" # FilesAppSharingContext::iShareWith()
│ Share action for file farewell.txt in file list could not be clicked
│ Exception message: Element is not currently visible and so may not be interacted with
│ Build info: version: '2.53.1', revision: 'a36b8b1', time: '2016-06-30 17:37:03'
│ System info: host: 'fda856cce78b', ip: '192.168.96.2', os.name: 'Linux', os.arch: 'amd64', os.version: '4.15.0-76-generic', java.version: '1.8.0_91'
│ Driver info: driver.version: unknown
│ Trying again
│ Share action for file farewell.txt in file list visibility could not be got
│ Exception message: Element not found with xpath, (((//html//*[starts-with(@id, 'app-content-') and not(contains(concat(' ', normalize-space(@class), ' '), ' hidden '))])[1]//*[@id = 'fileList']//span[contains(concat(' ', normalize-space(@class), ' '), ' nametext ') and normalize-space() = 'farewell.txt']/ancestor::tr)[1]/descendant-or-self::*[@class and contains(concat(' ', normalize-space(@class), ' '), ' action-share ')])[1]
│ │ Unable to locate element: {"method":"xpath","selector":"(((//html//*[starts-with(@id, 'app-content-') and not(contains(concat(' ', normalize-space(@class), ' '), ' hidden '))])[1]//*[@id = 'fileList']//span[contains(concat(' ', normalize-space(@class), ' '), ' nametext ') and normalize-space() = 'farewell.txt']/ancestor::tr)[1]/descendant-or-self::*[@class and contains(concat(' ', normalize-space(@class), ' '), ' action-share ')])[1]"}
│ For documentation on this error, please visit: http://seleniumhq.org/exceptions/no_such_element.html
│ Build info: version: '2.53.1', revision: 'a36b8b1', time: '2016-06-30 17:37:03'
│ System info: host: 'fda856cce78b', ip: '192.168.96.2', os.name: 'Linux', os.arch: 'amd64', os.version: '4.15.0-76-generic', java.version: '1.8.0_91'
│ Driver info: driver.version: unknown
│ Trying again
│ Row for file farewell.txt in file list could not be found after 100 seconds
Share action for file farewell.txt in file list could not be found after 100 seconds (NoSuchElementException)
And I see that the file is shared with "user0" # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
And I set the share with "user0" as not editable # FilesAppSharingContext::iSetTheShareWithAsNotEditable()
And I see that "user0" can not edit the share # FilesAppSharingContext::iSeeThatCanNotEditTheShare()
When I act as Jane # ActorContext::iActAs()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
And I share "farewell.txt" with "user1" # FilesAppSharingContext::iShareWith()
Then I see that the file is shared with "user1" # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
And I see that "user1" can not edit the share # FilesAppSharingContext::iSeeThatCanNotEditTheShare()
And I see that "user1" can not be allowed to edit the share # FilesAppSharingContext::iSeeThatCanNotBeAllowedToEditTheShare()

[skjnldsv]

Lots of jsunit issues

[dependabot]

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.