also load app autoloader when located in /vendor

[icewind1991]

with the phasing out of app.php apps can no longer load the autoloader from there themselves

See #21812

[icewind1991]

/backport to stable20

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 33536: failure

jsunit

Show full log

PhantomJS 2.1.1 (Linux 0.0.0) WARN: 'No OC found'
PhantomJS 2.1.1 (Linux 0.0.0) LOG: 'JQMIGRATE: Migrate is installed, version 1.4.1'
PhantomJS 2.1.1 (Linux 0.0.0) WARN: 'jQuery is deprecated: The global jQuery is deprecated. It will be updated to v3.x in Nextcloud 21. In later versions of Nextcloud it might be removed completely. Please ship your own.'
PhantomJS 2.1.1 (Linux 0.0.0) WARN: '$ is deprecated: The global jQuery is deprecated. It will be updated to v3.x in Nextcloud 21. In later versions of Nextcloud it might be removed completely. Please ship your own.'
PhantomJS 2.1.1 (Linux 0.0.0) WARN: 'Handlebars is deprecated: please ship your own, this will be removed in Nextcloud 20'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Files.Settings initialized'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Files.Sidebar initialized'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Sharing.ShareSearch initialized'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Sharing.ExternalLinkActions initialized'
PhantomJS 2.1.1 (Linux 0.0.0): Executed 847 of 850 (skipped 3) SUCCESS (11.135 secs / 10.562 secs)

[ChristophWurst]

with the phasing out of app.php apps can no longer load the autoloader from there themselves

But you can require_once from the header of Application.php, no?

[MorrisJobke]

with the phasing out of app.php apps can no longer load the autoloader from there themselves

But you can require_once from the header of Application.php, no?

Or just put it in composer/autoloader.php?

[juliusknorr]

👍 from my side since vendor is actually the default target directory for installing composer packages without additional configuration of the vendor-dir

[ChristophWurst]

well fine I guess

[ChristophWurst]

argh I'm so torn on this one. we have to check the file existence for every app. the os/fs will cache the result but still we do this. and if the require_once is in application.php (and we properly document this) it's explicit and less magical.

[MorrisJobke]

and if the require_once is in application.php (and we properly document this) it's explicit and less magical.

Sounds sane 👍

[ChristophWurst]

Then I'll change my mind one more time. I'll do the docs update.