Uh oh!
There was an error while loading. Please reload this page.
Mark all compiled JS as binary - #23136
Merged
Merged
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
requested review from
ChristophWurst, julien-nc, rullzer and skjnldsvOctober 2, 2020 10:22
rullzer
approved these changes
Oct 2, 2020
skjnldsv
reviewed
Oct 2, 2020
Comment on lines
+4
to
+5
| /apps/accessibility/js/*.js binary | ||
| /apps/accessibility/js/*.js.map binary |
Member
There was a problem hiding this comment.
We could probably even do 😛
Suggested change
| /apps/accessibility/js/*.jsbinary | |
| /apps/accessibility/js/*.js.mapbinary | |
| /apps/*/js/*.jsbinary | |
| /apps/*/js/*.js.mapbinary |
MemberAuthor
There was a problem hiding this comment.
But we still have non-compiled js files 😨
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 33553: failuremariadb10.1-php7.3
|
skjnldsv
approved these changes
Oct 2, 2020
nickvergessen
commented
Oct 2, 2020
MemberAuthor
/backport to stable20 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joas Schilling coding@schilljs.com