Uh oh!
There was an error while loading. Please reload this page.
[stable19] dont hold a transaction during the move to trash - #23186
Merged
Conversation
backportbot-nextcloudBot
requested review from
icewind1991, juliusknorr, nickvergessen and rullzerOctober 5, 2020 13:09
because moving to trash can take a long time, keeping a transaction active for the duration can lead to issues Signed-off-by: Robin Appelman <robin@icewind.nl>
nickvergessenforce-pushed
the
backport/23109/stable19
branch
from
October 5, 2020 13:27
f8bf210 to
f6bf519Comparejuliusknorr
approved these changes
Oct 6, 2020
MorrisJobke
commented
Oct 6, 2020
Member
19.0.4 or 19.0.5 due to RC phase? cc @rullzer |
MorrisJobke
commented
Oct 6, 2020
Member
Got this during the RC testing and quite some positive testing feedback so this is for 19.0.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #23109