Skip to content

Format code to a single space around binary operators - #23189

Merged
MorrisJobke merged 1 commit into
masterfrom
enhancement/cs/binary_operator_spaces
Oct 5, 2020
Merged

Format code to a single space around binary operators#23189
MorrisJobke merged 1 commit into
masterfrom
enhancement/cs/binary_operator_spaces

Conversation

@ChristophWurst

@ChristophWurstChristophWurst commented Oct 5, 2020

Copy link
Copy Markdown
Member

This should give the code more consistency. See nextcloud/coding-standard#1 for the propose CS fixer change.

@MorrisJobke

Copy link
Copy Markdown
Member

CI says no ❌

@faily-bot

faily-botBot commented Oct 5, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 33665: failure

sqlite

Show full log
There were 2 errors:
1) OCA\DAV\Tests\Unit\Connector\Sabre\DirectoryTest::testGetQuotaInfoUnlimited
Undefined offset: 3
/drone/src/lib/private/legacy/OC_Helper.php:548
/drone/src/apps/dav/lib/Connector/Sabre/Directory.php:331
/drone/src/apps/dav/tests/unit/Connector/Sabre/DirectoryTest.php:308
2) OCA\DAV\Tests\Unit\Connector\Sabre\DirectoryTest::testGetQuotaInfoSpecific
Undefined offset: 3
/drone/src/lib/private/legacy/OC_Helper.php:548
/drone/src/apps/dav/lib/Connector/Sabre/Directory.php:331
/drone/src/apps/dav/tests/unit/Connector/Sabre/DirectoryTest.php:347
--
There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

mariadb10.1-php7.3

mariadb10.4-php7.4

mysql8.0-php7.4

mysql5.6-php7.3

postgres9-php7.3

Show full log
There were 2 errors:
1) OCA\DAV\Tests\Unit\Connector\Sabre\DirectoryTest::testGetQuotaInfoUnlimited
Undefined offset: 3
/drone/src/lib/private/legacy/OC_Helper.php:548
/drone/src/apps/dav/lib/Connector/Sabre/Directory.php:331
/drone/src/apps/dav/tests/unit/Connector/Sabre/DirectoryTest.php:308
2) OCA\DAV\Tests\Unit\Connector\Sabre\DirectoryTest::testGetQuotaInfoSpecific
Undefined offset: 3
/drone/src/lib/private/legacy/OC_Helper.php:548
/drone/src/apps/dav/lib/Connector/Sabre/Directory.php:331
/drone/src/apps/dav/tests/unit/Connector/Sabre/DirectoryTest.php:347
--
There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

postgres11-php7.4

@kesselb

Copy link
Copy Markdown
Contributor

CI says no x

#23193

@MorrisJobke

Copy link
Copy Markdown
Member

CI says no x

#23193

Let's see if this is true and rebase this one here.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@MorrisJobke
MorrisJobkeforce-pushed the enhancement/cs/binary_operator_spaces branch from 114fcf4 to d9015a8CompareOctober 5, 2020 18:25
@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 5, 2020
@MorrisJobke

Copy link
Copy Markdown
Member

Looks good 👍

@MorrisJobke
MorrisJobke merged commit 0f7fb7c into masterOct 5, 2020
@MorrisJobke
MorrisJobke deleted the enhancement/cs/binary_operator_spaces branch October 5, 2020 19:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@ChristophWurst@MorrisJobke@kesselb@phsc84