Skip to content

Deprecate the named alias of IBus - #23245

Merged
rullzer merged 1 commit into
masterfrom
techdebt/server-bus-deprecate-alias
Oct 8, 2020
Merged

Deprecate the named alias of IBus#23245
rullzer merged 1 commit into
masterfrom
techdebt/server-bus-deprecate-alias

Conversation

@ChristophWurst

Copy link
Copy Markdown
Member

Btw @icewind1991 is this bus even used? If not, can we deprecate it?

@ChristophWurstChristophWurst added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 pending documentation This pull request needs an associated documentation update labels Oct 7, 2020
@ChristophWurstChristophWurst added this to the Nextcloud 21 milestone Oct 7, 2020
@ChristophWurstChristophWurst self-assigned this Oct 7, 2020
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurstChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 7, 2020
@ChristophWurst
ChristophWurstforce-pushed the techdebt/server-bus-deprecate-alias branch from 0329d9a to 6a63d7bCompareOctober 7, 2020 16:58
@faily-bot

faily-botBot commented Oct 7, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 33809: failure

sqlite

Show full log
There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
--
There was 1 failure:
1) TrashbinTest::testExpireOldFilesShared
Failed asserting that 3 is identical to 2.
/drone/src/apps/files_trashbin/tests/TrashbinTest.php:304
/drone/src/apps/files_trashbin/tests/TrashbinTest.php:287

mariadb10.1-php7.3

mariadb10.4-php7.4

mysql8.0-php7.4

mysql5.6-php7.3

postgres9-php7.3

Show full log
There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
--
There was 1 failure:
1) TrashbinTest::testExpireOldFilesShared
Failed asserting that 3 is identical to 2.
/drone/src/apps/files_trashbin/tests/TrashbinTest.php:304
/drone/src/apps/files_trashbin/tests/TrashbinTest.php:287

postgres11-php7.4

@rullzer
rullzer merged commit fa374ac into masterOct 8, 2020
@rullzer
rullzer deleted the techdebt/server-bus-deprecate-alias branch October 8, 2020 09:50
MorrisJobke added a commit that referenced this pull request Oct 12, 2020
…e tests
Followup to #23245
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke

Copy link
Copy Markdown
Member

This broke master. The fix is in #23391

@ChristophWurstChristophWurst removed the pending documentation This pull request needs an associated documentation update label Nov 14, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishtechnical debt🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@ChristophWurst@MorrisJobke@nickvergessen@juliusknorr@rullzer