Skip to content

Fix sidebar updateTabs method - #23271

Merged
skjnldsv merged 1 commit into
stable20from
fix/sidebar-updateTabs
Oct 8, 2020
Merged

Fix sidebar updateTabs method#23271
skjnldsv merged 1 commit into
stable20from
fix/sidebar-updateTabs

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Oct 8, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Needed for 20! ⚠️
Fixnextcloud/photos#467

@skjnldsvskjnldsv added 3. to review Waiting for reviews bug feature: file sidebar Related to the file sidebar component high regression labels Oct 8, 2020
@skjnldsvskjnldsv self-assigned this Oct 8, 2020
@skjnldsvskjnldsv added this to the Nextcloud 20.0.1 milestone Oct 8, 2020
@skjnldsv

skjnldsv commented Oct 8, 2020

Copy link
Copy Markdown
MemberAuthor

/compile amend /

@skjnldsvskjnldsv changed the title improve handling of out of space errors for smbFix sidebar updateTabs methodOct 8, 2020
@skjnldsv

skjnldsv commented Oct 8, 2020

Copy link
Copy Markdown
MemberAuthor

@skjnldsvskjnldsv changed the title improve handling of out of space errors for smb Fix sidebar updateTabs method maintenant

Go home Github, you're drunk!

juliusknorr
juliusknorr reviewed Oct 8, 2020
View reviewed changes
Comment threadapps/files/src/views/Sidebar.vue
@skjnldsv
skjnldsvforce-pushed the fix/sidebar-updateTabs branch from db2ec75 to 87e59eaCompareOctober 8, 2020 09:23
@skjnldsv

skjnldsv commented Oct 8, 2020

Copy link
Copy Markdown
MemberAuthor

/compile amend /

@skjnldsv@npmbuildbot
Fix sidebar updateTabs method
fbf77cb
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@faily-bot

faily-botBot commented Oct 8, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 33838: failure

mysql5.6-php7.2

Show full log
There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
--
There was 1 failure:
1) OCA\Files_Versions\Tests\VersioningTest::testRestoreMovedShare
File content has not changed
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'version 2'
+'version 1'
/drone/src/apps/files_versions/tests/VersioningTest.php:729

acceptance-app-files

  • tests/acceptance/features/app-files.feature:108
Show full log
 Scenario: show shares # /drone/src/tests/acceptance/features/app-files.feature:108
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I share the link for "welcome.txt" # FilesAppSharingContext::iShareTheLinkFor()
When I open the "Shares" section # AppNavigationContext::iOpenTheSection()
Then I see that the current section is "Shares" # AppNavigationContext::iSeeThatTheCurrentSectionIs()
Then I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
Row for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)

@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 8, 2020
@skjnldsv
skjnldsv merged commit c578b11 into stable20Oct 8, 2020
@skjnldsv
skjnldsv deleted the fix/sidebar-updateTabs branch October 8, 2020 10:26
@MorrisJobke

MorrisJobke commented Oct 12, 2020

Copy link
Copy Markdown
Member

/backport to stable20

@skjnldsv

skjnldsv commented Oct 12, 2020

Copy link
Copy Markdown
MemberAuthor

@MorrisJobke that was on stable20

@skjnldsv

skjnldsv commented Oct 12, 2020

Copy link
Copy Markdown
MemberAuthor

master have it alongside other changes, I backported this only

@backportbot-nextcloud

backportbot-nextcloudBot commented Oct 12, 2020

Copy link
Copy Markdown

The backport to stable20 failed. Please do this backport manually.

@MorrisJobke

MorrisJobke commented Oct 12, 2020

Copy link
Copy Markdown
Member

🙈

@MorrisJobkeMorrisJobke mentioned this pull request Oct 15, 2020
Merged
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@juliusknorrjuliusknorrjuliusknorr approved these changes
@MorrisJobkeMorrisJobkeAwaiting requested review from MorrisJobke
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst
@julien-ncjulien-ncAwaiting requested review from julien-nc

Assignees

@skjnldsvskjnldsv

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: file sidebarRelated to the file sidebar componenthighregression

Projects

None yet

Milestone

Nextcloud 20.0.1

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv@MorrisJobke@rullzer@juliusknorr