Uh oh!
There was an error while loading. Please reload this page.
Fix the escapeHTML issue with files_external app - #23293
Closed
sharidas wants to merge 1 commit into
Closed
Conversation
The files_external app uses escapeHTML. This change helps fix the UI of the external storage. Signed-off-by: Sujith Haridasan <sujith.h@gmail.com>
sharidas
commented
Oct 8, 2020
ContributorAuthor
SummaryThe user when tries to add external storage in the admin->settings page, the DescriptionThe Note: Let me know if this looks ok? How was it tested?
|
Contributor
We can also go for this approach. I don't have a strong opinion ;) |
sharidas
commented
Oct 8, 2020
ContributorAuthor
I didn't knew about your PR :( Sorry for my duplicate PR ... |
sharidas
commented
Oct 9, 2020
ContributorAuthor
I am closing this PR as it becomes a duplicate to #23264. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The files_external app uses escapeHTML. This change
helps fix the UI of the external storage.
Signed-off-by: Sujith Haridasan sujith.h@gmail.com