Uh oh!
There was an error while loading. Please reload this page.
Add Psalm type for the bootstrap registration context - #23371
Merged
ChristophWurst merged 1 commit intoOct 12, 2020
Merged
Conversation
ChristophWurst
requested review from
MorrisJobke, juliusknorr, kesselb and nickvergessenOctober 12, 2020 09:27
ChristophWurst
commented
Oct 12, 2020
MemberAuthor
/backport to stable20 |
ChristophWurst
commented
Oct 12, 2020
MemberAuthor
/backport to stable19 |
ChristophWurst
commented
Oct 12, 2020
MemberAuthor
kesselb
approved these changes
Oct 12, 2020
ChristophWurstforce-pushed
the
enhancement/psalm-typed-bootstrap-registration-context
branch
from
October 12, 2020 13:16
cae71af to
ad58771CompareThis can potentially catch a few bugs with wrong class strings. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurstforce-pushed
the
enhancement/psalm-typed-bootstrap-registration-context
branch
from
October 12, 2020 13:16
ad58771 to
ccfe6a9Compare🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 34000: failuresqliteShow full logmariadb10.1-php7.3
mariadb10.4-php7.4
mysql8.0-php7.4
mysql5.6-php7.3
postgres9-php7.3Show full logpostgres11-php7.4
|
ChristophWurst
deleted the
enhancement/psalm-typed-bootstrap-registration-context
branch
October 12, 2020 15:14
The backport to stable19 failed. Please do this backport manually. |
MorrisJobke
commented
Nov 3, 2020
Member
@ChristophWurst Psalm is 20+ only anyways |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This can potentially catch a few bugs with wrong class strings.
Typed code is good code.
Kind-of follow-up to #23310 but not necessarily related.