Uh oh!
There was an error while loading. Please reload this page.
Fix typo 'shared' - #23378
Merged
Merged
Conversation
ChristophWurst
commented
Oct 12, 2020
Member
/backport to stable20 |
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
approved these changes
Oct 12, 2020
MorrisJobke
left a comment
Member
There was a problem hiding this comment.
I just pushed the code style fix 👍
kesselb
approved these changes
Oct 12, 2020
kesselb
reviewed
Oct 12, 2020
| ]); | ||
| } | ||
| public function dataProvider_TrueFalse() { |
Contributor
There was a problem hiding this comment.
Naming is a bit uncommon but might be okay for tests.
MemberAuthor
There was a problem hiding this comment.
It's just the way i name it in my app tests. What would be your suggestion for data provider functions?
Contributor
There was a problem hiding this comment.
I don't see any convention how to name data providers right now. I would prefer to not mix snake_case and camelCase but we can also merge this.
MorrisJobke
commented
Oct 12, 2020
Member
CI failures are unrelated and are broken on master as well 🙈 |
The backport to stable20 failed. Please do this backport manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of
RegistrationContext.registerServicedoes not recognize the$shared-parameter correctly because of a typo.