Skip to content

Expose CLOUD federation for local users in the recent addressbook - #23379

Merged
skjnldsv merged 2 commits into
masterfrom
fix/recent-contacts-federated
Oct 12, 2020
Merged

Expose CLOUD federation for local users in the recent addressbook#23379
skjnldsv merged 2 commits into
masterfrom
fix/recent-contacts-federated

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Oct 12, 2020

Copy link
Copy Markdown
Member

If we want to show the users as local users on contacts we need to be able to match them.
I'll use the official CLOUD property like #23199 will implement too

Recents stays recent for 7 days, after they get destroyed. I'm fine with that, no need for a migration. The data will get update over time

@skjnldsvskjnldsv added bug 3. to review Waiting for reviews labels Oct 12, 2020
@skjnldsvskjnldsv added this to the Nextcloud 21 milestone Oct 12, 2020
@skjnldsvskjnldsv self-assigned this Oct 12, 2020

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 12, 2020
Comment threadapps/files_sharing/lib/Listener/ShareInteractionListener.php Outdated
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
skjnldsvforce-pushed the fix/recent-contacts-federated branch from bded261 to 698d4f5CompareOctober 12, 2020 13:17
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
skjnldsv requested a review from kesselbOctober 12, 2020 14:57
@skjnldsvskjnldsv changed the title Expose CLOUD federation for local users as wellExpose CLOUD federation for local users in the recent addressbookOct 12, 2020
@faily-bot

faily-botBot commented Oct 12, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34003: failure

sqlite

Show full log
There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
--
There was 1 failure:
1) TrashbinTest::testExpireOldFilesShared
Failed asserting that 3 is identical to 2.
/drone/src/apps/files_trashbin/tests/TrashbinTest.php:304
/drone/src/apps/files_trashbin/tests/TrashbinTest.php:287

mariadb10.1-php7.3

mariadb10.4-php7.4

mysql8.0-php7.4

mysql5.6-php7.3

postgres9-php7.3

Show full log
There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
--
There was 1 failure:
1) TrashbinTest::testExpireOldFilesShared
Failed asserting that 3 is identical to 2.
/drone/src/apps/files_trashbin/tests/TrashbinTest.php:304
/drone/src/apps/files_trashbin/tests/TrashbinTest.php:287

postgres11-php7.4

@skjnldsv
skjnldsv merged commit ff84fc4 into masterOct 12, 2020
@skjnldsv
skjnldsv deleted the fix/recent-contacts-federated branch October 12, 2020 16:40
@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/backport to stable20

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv@MorrisJobke@ChristophWurst@kesselb