Skip to content

Fix filepicker styling - #2342

Merged
LukasReschke merged 5 commits into
masterfrom
filepicker-shadow
Nov 28, 2016
Merged

Fix filepicker styling#2342
LukasReschke merged 5 commits into
masterfrom
filepicker-shadow

Conversation

@icewind1991

Copy link
Copy Markdown
Member

Fixes#2252

Also now limits the filepicker size to fit in small screens.

cc @jancborchardt@LukasReschke

Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991icewind1991 added the 3. to review Waiting for reviews label Nov 25, 2016
@icewind1991icewind1991 added this to the Nextcloud 11.0 milestone Nov 25, 2016
@mention-bot

Copy link
Copy Markdown

@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tanghus, @PVince81 and @jancborchardt to be potential reviewers.

@MorrisJobke

MorrisJobke commented Nov 25, 2016

Copy link
Copy Markdown
Member

Really nice. There is only one issue:

  • cause a file conflict dialog and then resize the window: the modal is always increasing size and can't be closed anymore, because the elements are out of the view

@MorrisJobkeMorrisJobke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Nov 25, 2016
@MorrisJobke

Copy link
Copy Markdown
Member

Potentially also fixes #1864

Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991

Copy link
Copy Markdown
MemberAuthor

cause a file conflict dialog and then resize the window: the modal is always increasing size and can't be closed anymore, because the elements are out of the view

Fixed

@MorrisJobkeMorrisJobke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 28, 2016
@MorrisJobke

Copy link
Copy Markdown
Member

Tested and works 👍

@MorrisJobke

Copy link
Copy Markdown
Member

Tested and works 👍

Chrome, Safari, IE11 and Edge ;)

@LukasReschke

Copy link
Copy Markdown
Member

LGTM

@LukasReschkeLukasReschke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 28, 2016
@codecov-io

Copy link
Copy Markdown

Current coverage is 57.03% (diff: 0.00%)

Merging #2342 into master will decrease coverage by 0.03%

@@ master #2342 diff @@
==========================================
Files 1191 1191 Lines 71911 72140 +229 Methods 7299 7335 +36 Messages 0 0 Branches 1213 1226 +13 ==========================================
+ Hits 41036 41142 +106 - Misses 30875 30998 +123 
Partials 0 0 

Powered by Codecov. Last update 4764679...b2b9abf

@LukasReschke
LukasReschke merged commit 183bee9 into masterNov 28, 2016
@LukasReschke
LukasReschke deleted the filepicker-shadow branch November 28, 2016 14:00
leonklingele pushed a commit to strukturag/nextcloud-spreedme that referenced this pull request Nov 28, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@icewind1991@mention-bot@MorrisJobke@LukasReschke@codecov-io