Skip to content

[Minor] Fix link to external storage settings on error notification - #2343

Merged
nickvergessen merged 1 commit into
masterfrom
fix-exteranl-storage-redirect
Nov 27, 2016
Merged

[Minor] Fix link to external storage settings on error notification#2343
nickvergessen merged 1 commit into
masterfrom
fix-exteranl-storage-redirect

Conversation

@eppfel

@eppfeleppfel commented Nov 26, 2016

Copy link
Copy Markdown
Member

The link still redirected to the old #link settings/admin#files_external.

I have searched the repo for other occurrences, but found only core/js/integritycheck-failed-notification.js and I#m not sure, if it has to be changed as well.

@nickvergessen@icewind1991@MorrisJobke

Signed-off-by: Felix A. Epp <work@felixepp.de>
@mention-bot

Copy link
Copy Markdown

@eppfel, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jmaciasportela, @icewind1991 and @PVince81 to be potential reviewers.

@MorrisJobke

Copy link
Copy Markdown
Member

Tested and works 👍

cc @nickvergessen@LukasReschke@MariusBluem

@icewind1991

Copy link
Copy Markdown
Member

👍

@eppfeleppfel added 4. to release Ready to be released and/or waiting for tests to finish and removed 4. to release Ready to be released and/or waiting for tests to finish labels Nov 27, 2016
@eppfel

Copy link
Copy Markdown
MemberAuthor

What's with the codecov?

@nickvergessen
nickvergessen merged commit 7e6f829 into masterNov 27, 2016
@nickvergessen
nickvergessen deleted the fix-exteranl-storage-redirect branch November 27, 2016 08:02
@nickvergessen

Copy link
Copy Markdown
Member

Codecov just tells you that the changed lines are not covered by tests

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@eppfel@mention-bot@MorrisJobke@icewind1991@nickvergessen