Uh oh!
There was an error while loading. Please reload this page.
SCSSCacher - Lock should not be removed - #23488
Merged
Merged
Conversation
MorrisJobke
requested review from
ChristophWurst, juliusknorr, kesselb and nickvergessenOctober 15, 2020 21:51
MorrisJobke
commented
Oct 15, 2020
MemberAuthor
/backport to stable20 |
MorrisJobke
commented
Oct 15, 2020
MemberAuthor
/backport to stable19 |
MorrisJobke
commented
Oct 15, 2020
MemberAuthor
/backport to stable18 |
skjnldsv
approved these changes
Oct 16, 2020
ChristophWurst
approved these changes
Oct 16, 2020
ChristophWurst
left a comment
Member
There was a problem hiding this comment.
A bit unsure if this is right, can't quite wrap my head around it but I'd say worth a try on an effected production instance
This is within the failed lock acquiring branch. So the lock is free by another process and should not be removed because the cached file (that was created by the process having the lock) appeared on the filesystem. Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobkeforce-pushed
the
fix/noid/no-lock-removal-scss-cacher
branch
from
October 16, 2020 08:02
266a00c to
9273436CompareMorrisJobke
commented
Oct 16, 2020
MemberAuthor
Rebased to fix the conflict with #23490 |
juliusknorr
approved these changes
Oct 16, 2020
This was referenced Oct 16, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is within the failed lock acquiring branch. So the lock is free by another process and should not be removed because the cached file (that was created by the process having the lock) appeared on the filesystem.
This is part of multiple PRs. I just split them into their smallest independent parts. Other parts: #23478#23490