Uh oh!
There was an error while loading. Please reload this page.
Add app:check-code for already compatible apps - #235
Merged
Conversation
* admin_audit, comments, federation * removed not needed call to OC_Util::checkAdminUser() (is already done by the request handler before)
LukasReschke
commented
Jun 27, 2016
Member
👍 |
MorrisJobke
commented
Jun 27, 2016
MemberAuthor
@Mar1u5 ;) |
MariusBluem
commented
Jun 27, 2016
Member
I am not completely understanding what the two points of the PR have to do with each other 😁 checkAdminUser() has nothing to do with Travis - has it 😅 |
MorrisJobke
commented
Jun 27, 2016
MemberAuthor
It has: the one is an unneeded call (we do this already internally) and it is a call to a private method, that apps shouldn't do. If they do, then the app:check-code would fail ;) |
Member
Okay ... Now I understand. I've tested it and i could not find any problems 😉 LGTM :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
done by the request handler before)
cc @LukasReschke@schiessle