Uh oh!
There was an error while loading. Please reload this page.
manifest to report correct favicon size - #23520
Merged
Merged
Conversation
This was referenced Oct 16, 2020
In the environment where php-imagick with SVG support is correctly installed, this endpoint returns 512x512 image. https://github.com/nextcloud/server/blob/d9015a8c94bfd71fe484618a06d276701d3bf9ff/apps/theming/lib/Controller/IconController.php#L146 The problem is in the environment without php-imagick or without SVG support, this will fall back to original, whose default is 128x128; but I thought this is a separate problem. (For this, default image may be enlarged. Should I create another issue if this is important one?) Signed-off-by: nhirokinet <nhirokinet@nhiroki.net>
rullzer
requested review from
ChristophWurst, MorrisJobke, juliusknorr, rullzer and skjnldsvOctober 19, 2020 12:52
rullzer
approved these changes
Oct 19, 2020
skjnldsv
commented
Oct 20, 2020
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the environment where php-imagick with SVG support is correctly installed, this endpoint returns 512x512 image.
server/apps/theming/lib/Controller/IconController.php
Line 146 in d9015a8
Another problem here is in the environment without php-imagick or without SVG support, this will fall back to original, whose default is 128x128; but I thought this is a separate problem. (For this, default image may be enlarged. Should I create another issue if this is important one?)