Settings: new user row replaced by a modal by Simounet · Pull Request #23529 · nextcloud/server

Simounet · 2020-10-16T18:50:20Z

Hi there,
I know that I have to commit the compiled files but I need some help here. make watch-js changes files without me touching anything.
Another issue is that on modal opening, the HTML validation displays error on password and mail inputs. Did I miss something here because it wasn't an issue before.

Here is a screenshot of the result:

Linked to #23397.

Have a good night and stay safe.

kesselb · 2020-10-16T19:43:04Z

/compile amend /

kesselb · 2020-10-16T19:45:39Z

make watch-js changes files without me touching anything.

I have the same issue from time to time. Usually fixed by rm -rf node_modules. Maybe not bad to use node 12.x. Super cool enhancement and much better then before 👍

Simounet · 2020-10-16T20:04:32Z

I tried to clean my env but it's not working. I'm running Node v12.14.1.

AndyXheli · 2020-10-21T16:17:22Z

@jancborchardt What do you think about this?

Simounet · 2020-10-22T09:28:40Z

I put the display name first and the popin is larger.

The last issue here is about the HTML validation when the popin appears.

kesselb · 2020-10-22T10:08:39Z

cc @skjnldsv any idea why the form validation triggers on modal open?

skjnldsv · 2020-10-22T10:10:09Z

cc @skjnldsv any idea why the form validation triggers on modal open?

Probably a chaining events. Make sure you use an event stop on the button

kesselb · 2020-10-22T10:23:11Z

Or it's probably the default behaviour 🤔

https://developer.mozilla.org/en-US/docs/Learn/Forms/Form_validation
https://mdn.github.io/learning-area/html/forms/form-validation/full-example.html

Each element with required get the :invalid state.

skjnldsv · 2020-10-22T10:24:49Z

Ah, I misunderstod "form validation". I understood that as "submit". :)
Yes, it's normal if you use field types

Simounet · 2020-10-22T12:45:43Z

I get what was bothering me. Previous style override the red border so I put that here. It's not perfect but it's better than having red border without touching anything.

AndyXheli · 2020-10-22T18:34:17Z

I put the display name first and the popin is larger.
The last issue here is about the HTML validation when the popin appears.

Looks good!! Nice work

skjnldsv · 2020-10-23T08:56:02Z

+	.modal__content::v-deep .multiselect__single {
+ text-align: left;
+ box-sizing: border-box;
+	}
+	.modal__content::v-deep .multiselect__content-wrapper {
+ box-sizing: border-box;
+	}


Seems like an odd change, why was it needed?

Because of the default border of 1px on each side. Without changing the box sizing, I have 2 extra pixels.

skjnldsv

A few comments. Please abuse comments on your css code, especially v-deeps. Otherwise we don't know why you had to do it and maintaining is complicated :)

Same for other functions, it's a good habit to put more comments. It will get stripped for the build anyway, file size doesn't matter here.

Simounet · 2020-10-23T09:20:26Z

Ahah, some people love comments where some others don't. I will remember that they are appreciated here. :)

AndyXheli · 2021-02-26T15:03:57Z

@Simounet is there still an issue with the code ?

skjnldsv · 2021-03-02T06:46:45Z

I think the acceptance test fail is valid.
@Simounet can you rebase?

julien-nc

Code looks sane, the modal is much nicer!

Simounet · 2021-03-02T11:57:02Z

I rebased and push. Just waiting for the CI.

danxuliu · 2021-03-08T04:21:43Z

Sorry a lot for the delay.

#25991 updates the browser used in the acceptance tests to a recent version. With that recent version the dialog works as expected :-)

However, turns out that the header test was wrong! It was trying to add the user "user1", but that user is already added when installing and configuring the server, so it is already added in all tests. Thus, even if the dialog worked properly, the test would also fail because adding the user would fail, the dialog would not be closed, and the following steps would fail. The header test is fixed by #25990

Due to all that this pull request should be rebased on master once #25990 and #25991 are both merged and everything should then work (I have also added a fixup commit to this pull request to do a minor adjustment).

Simounet · 2021-03-08T07:55:11Z

I can't wait to see this PR merged! Thanks for the reply. I don't get why you removed my test to check if the modal is not here. Is it somewhere else on your PRs?

kesselb · 2021-03-16T14:51:13Z

Hi @Simounet,

mind to rebase your branch another time?

danxuliu · 2021-04-21T11:18:45Z

#25991 has been finally merged, so I took the liberty to rebase this pull request to latest master :-)

I don't get why you removed my test to check if the modal is not here. Is it somewhere else on your PRs?

Sorry, I missed the question. I removed the check because I think that it is not strictly needed in that scenario. When possible the acceptance tests should not go into specific details like whether a modal is used or not, and in this case it should be enough to just verify that the user was indeed added to the list to continue.

Of course it could happen that the modal was not properly closed, so a check for that could still be added in the scenarios related to user creation, or inside the step I create user :user with password :password (as that is a high level step that abstracts a "complex" action, and the modal being closed would be part of that action). But for me it still feels like something not being tested at the right scope, so I did not add it :-)

AndyXheli · 2021-04-21T11:23:00Z

this is finally happening 🙏🏻😁 super excited

Signed-off-by: Simounet <contact@simounet.net>

skjnldsv · 2021-04-21T14:39:08Z

All tests passed! Well done!! 🎉 🚀

Simounet · 2021-04-21T14:41:20Z

Glad to see this finally merged! Thank you everyone for your support in my first real PR on this amazing piece of software.
Hope you'll enjoy this "feature" @AndyXheli ! :D

AndyXheli · 2021-04-21T14:43:08Z

Glad to see this finally merged! Thank you everyone for your support in my first real PR on this amazing piece of software.
Hope you'll enjoy this "feature" @AndyXheli ! :D

Thank you so much brother for making this happen. Definitely will 😁 have a nice day.

Simounet requested a review from jancborchardt October 16, 2020 18:50

Simounet mentioned this pull request Oct 16, 2020
Add new user content boxes not aligned #23397
Closed

kesselb added 2. developing Work in progress enhancement labels Oct 16, 2020

npmbuildbot-nextcloudBotforce-pushed the feat/23397-settings-new-user-modal branch from c4a2556 to 3ad7608Compare October 16, 2020 19:55

Simounet force-pushed the feat/23397-settings-new-user-modal branch 3 times, most recently from 9580d81 to 71c6c9cCompare October 20, 2020 19:27

Simounet force-pushed the feat/23397-settings-new-user-modal branch from 71c6c9c to 9d40928Compare October 22, 2020 09:26

kesselb reviewed Oct 22, 2020
View reviewed changes

Comment threadapps/settings/src/components/UserList.vue Outdated

Simounet force-pushed the feat/23397-settings-new-user-modal branch from 9d40928 to 901c829Compare October 22, 2020 12:43

skjnldsv reviewed Oct 23, 2020
View reviewed changes

Comment threadapps/settings/src/components/UserList.vue Outdated

skjnldsv reviewed Oct 23, 2020
View reviewed changes

Comment threadapps/settings/src/views/Users.vue Outdated

skjnldsv reviewed Oct 23, 2020
View reviewed changes

Comment threadapps/settings/src/components/UserList.vue Outdated

skjnldsv reviewed Oct 23, 2020
View reviewed changes

skjnldsv requested changes Oct 23, 2020
View reviewed changes

skjnldsv added the feature: users and groups label Oct 23, 2020

Simounet force-pushed the feat/23397-settings-new-user-modal branch from 901c829 to d29f986Compare October 23, 2020 12:24

rullzer added this to the Nextcloud 22 milestone Jan 8, 2021

This comment has been minimized.
Sign in to view

Simounet force-pushed the feat/23397-settings-new-user-modal branch 3 times, most recently from e44c87f to 075201bCompare February 23, 2021 19:17

skjnldsv requested review from PVince81 and julien-nc March 2, 2021 06:47

julien-nc approved these changes Mar 2, 2021
View reviewed changes

Simounet force-pushed the feat/23397-settings-new-user-modal branch from 075201b to 220fd3fCompare March 2, 2021 11:03

Simounet force-pushed the feat/23397-settings-new-user-modal branch from 66a1241 to fcba309Compare March 16, 2021 20:39

danxuliu force-pushed the feat/23397-settings-new-user-modal branch from fcba309 to e01bdd7Compare April 21, 2021 11:17

Settings: new user row replaced by a modal
45c3b2a
Signed-off-by: Simounet <contact@simounet.net>

Simounet force-pushed the feat/23397-settings-new-user-modal branch from e01bdd7 to 45c3b2aCompare April 21, 2021 12:43

skjnldsv merged commit 3da956b into nextcloud:masterApr 21, 2021

skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Apr 21, 2021

Simounet deleted the feat/23397-settings-new-user-modal branch April 21, 2021 14:41

This was referenced May 20, 2021
Allow to upload a profile picture in the create user dialog #2867
Open
Frontend validation for Add User form #11584
Closed

Uh oh!

Uh oh!

Conversation

Simounet commented Oct 16, 2020

Uh oh!

kesselb commented Oct 16, 2020

Uh oh!

kesselb commented Oct 16, 2020

Uh oh!

Simounet commented Oct 16, 2020

Uh oh!

AndyXheli commented Oct 21, 2020

Uh oh!

Simounet commented Oct 22, 2020

Uh oh!

kesselb commented Oct 22, 2020

Uh oh!

skjnldsv commented Oct 22, 2020

Uh oh!

Uh oh!

kesselb commented Oct 22, 2020

Uh oh!

skjnldsv commented Oct 22, 2020

Uh oh!

Simounet commented Oct 22, 2020

Uh oh!

AndyXheli commented Oct 22, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

skjnldsvOct 23, 2020

Choose a reason for hiding this comment

Uh oh!

SimounetOct 23, 2020

Choose a reason for hiding this comment

Uh oh!

skjnldsv left a comment

Choose a reason for hiding this comment

Uh oh!

Simounet commented Oct 23, 2020

Uh oh!

This comment has been minimized.

AndyXheli commented Feb 26, 2021

Uh oh!

skjnldsv commented Mar 2, 2021

Uh oh!

julien-nc left a comment

Choose a reason for hiding this comment

Uh oh!

Simounet commented Mar 2, 2021

Uh oh!

danxuliu commented Mar 8, 2021

Uh oh!

Simounet commented Mar 8, 2021

Uh oh!

kesselb commented Mar 16, 2021

Uh oh!

danxuliu commented Apr 21, 2021

Uh oh!

AndyXheli commented Apr 21, 2021

Uh oh!

skjnldsv commented Apr 21, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Simounet commented Apr 21, 2021

Uh oh!

AndyXheli commented Apr 21, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

skjnldsv commented Apr 21, 2021•
edited
Loading