Skip to content

[stable19] CalDavBackend: check if timerange is array before accessing - #23564

Merged
MorrisJobke merged 1 commit into
stable19from
backport/23497/stable19
Oct 20, 2020
Merged

[stable19] CalDavBackend: check if timerange is array before accessing#23564
MorrisJobke merged 1 commit into
stable19from
backport/23497/stable19

Conversation

@backportbot-nextcloud

@backportbot-nextcloudbackportbot-nextcloudBot commented Oct 19, 2020

Copy link
Copy Markdown

backport of #23497

Simon Spannagel@backportbot
CalDavBackend: check if timerange is array before accessing
afb88e7
Signed-off-by: Simon Spannagel <simonspa@kth.se>
@backportbot-nextcloudbackportbot-nextcloudBot added this to the Nextcloud 19.0.5 milestone Oct 19, 2020
@faily-bot

faily-botBot commented Oct 19, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34338: failure

acceptance-app-files

  • tests/acceptance/features/app-files.feature:108
Show full log
 Scenario: show shares # /drone/src/tests/acceptance/features/app-files.feature:108
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I share the link for "welcome.txt" # FilesAppSharingContext::iShareTheLinkFor()
When I open the "Shares" section # AppNavigationContext::iOpenTheSection()
Then I see that the current section is "Shares" # AppNavigationContext::iSeeThatTheCurrentSectionIs()
Then I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
Row for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)

@rullzerrullzer added the 4. to release Ready to be released and/or waiting for tests to finish label Oct 19, 2020
@MorrisJobkeMorrisJobke mentioned this pull request Oct 20, 2020
Closed
@MorrisJobke
MorrisJobke merged commit 3157ff4 into stable19Oct 20, 2020
@MorrisJobke
MorrisJobke deleted the backport/23497/stable19 branch October 20, 2020 07:56
@rullzerrullzer mentioned this pull request Nov 9, 2020
Merged
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@simonspasimonspasimonspa approved these changes
@georgehrkegeorgehrkeAwaiting requested review from georgehrke
@kesselbkesselbAwaiting requested review from kesselb
@nickvergessennickvergessenAwaiting requested review from nickvergessen

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: dav

Projects

None yet

Milestone

Nextcloud 19.0.5

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer@simonspa@MorrisJobke