LDAP: when nesting is not enabled, the group filter can be applied right away

[blizzz]

When fetcher user groups, we may take groups into account that do not match the filter. This is necessary when using nesting and have intermediate groups, which members still ought to be pulled in. When nesting is not enabled, though, we can save the overhead.

• helps performance, but skipping unnecessary entries
• reduces reoccuring info-level log output against groups that do not
  qualify ("no or empty name")

[MorrisJobke]

Code looks good 👍

[blizzz]

/backport to stable20

[blizzz]

/backport to stable19

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34347: failure

acceptance-app-files-sharing

• tests/acceptance/features/app-files-sharing.feature:338

Show full log

 Scenario: sharee can revoke create permission from reshare after the sharer disabled it # /drone/src/tests/acceptance/features/app-files-sharing.feature:338
Given I act as John # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I act as Jane # ActorContext::iActAs()
And I am logged in # LoginPageContext::iAmLoggedIn()
And I act as Jim # ActorContext::iActAs()
And I am logged in as "user1" # LoginPageContext::iAmLoggedInAs()
And I act as John # ActorContext::iActAs()
And I create a new folder named "Shared folder" # FileListContext::iCreateANewFolderNamed()
And I see that the file list contains a file named "Shared folder" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
And I share "Shared folder" with "user0" # FilesAppSharingContext::iShareWith()
And I see that the file is shared with "user0" # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
And I act as Jane # ActorContext::iActAs()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
And I share "Shared folder" with "user1" # FilesAppSharingContext::iShareWith()
And I see that the file is shared with "user1" # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
And I act as John # ActorContext::iActAs()
And I set the share with "user0" as not creatable # FilesAppSharingContext::iSetTheShareWithAsNotCreatable()
And I see that "user0" can not create in the share # FilesAppSharingContext::iSeeThatCanNotCreateInTheShare()
And I act as Jim # ActorContext::iActAs()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
And I enter in the folder named "Shared folder" # FileListContext::iEnterInTheFolderNamed()
And I create a new folder named "Subfolder" # FileListContext::iCreateANewFolderNamed()
And I see that the file list contains a file named "Subfolder" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
When I act as Jane # ActorContext::iActAs()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
And I open the details view for "Shared folder" # FileListContext::iOpenTheDetailsViewFor()
And I see that the details view is open # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
And I open the "Sharing" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
And I see that the "Sharing" tab in the details view is eventually loaded # FilesAppContext::iSeeThatTheTabInTheDetailsViewIsEventuallyLoaded()
And I set the share with "user1" as not creatable # FilesAppSharingContext::iSetTheShareWithAsNotCreatable()
Then I see that "user1" can not create in the share # FilesAppSharingContext::iSeeThatCanNotCreateInTheShare()
And I see that "user1" can not be allowed to create in the share # FilesAppSharingContext::iSeeThatCanNotBeAllowedToCreateInTheShare()
And I act as Jim # ActorContext::iActAs()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
And I enter in the folder named "Shared folder" # FileListContext::iEnterInTheFolderNamed()
And I see that it is not possible to create new files # FileListContext::iSeeThatItIsNotPossibleToCreateNewFiles()
Failed asserting that true is false.