Override default dashboard background with theming one by julien-nc · Pull Request #23588 · nextcloud/server

julien-nc · 2020-10-20T10:42:07Z

If the override switch is on, the dashboard will look for a default background in "default" directory of dashboard's appdata.

This way the theming app just has to put an image there and toggle the config switch (it's not done yet).

@juliushaertl @jancborchardt Do you think it's a good way to do that?

jancborchardt · 2020-10-20T13:46:07Z

Right, so the idea would be that theming has a setting called "Use theming background for Dashboard" and it is then forced and non-changeable by users? Or is it just the default one in that case? (I’d prefer the latter.)

lzlrd · 2020-10-22T20:19:42Z

Could you possibly add a "no background" (as in, theme colour) option? That would just consoldate your patch and provide a config that covers all the cases a user themself could also pick from the GUI.

julien-nc · 2020-10-24T11:38:50Z

Or is it just the default one in that case?

@jancborchardt Yes it would just replace the default one, still letting users change it as usual.

Could you possibly add a "no background" (as in, theme colour) option?

@lazerl0rd Do you mean make the "plain background" as default? Yes it would be nice indeed.

lzlrd · 2020-10-24T13:21:03Z

@lazerl0rd Do you mean make the "plain background" as default? Yes it would be nice indeed.

Yupp, that's exactly what I meant.

skjnldsv · 2020-10-31T14:41:50Z

Ready for reviews?

julien-nc · 2020-10-31T14:52:06Z

@skjnldsv Still WIP. Dashboard side is ready but additional settings in theming app are still missing.

What do you think about the idea of using appdata to store the image set in theming app? Any other/better idea?

skjnldsv · 2020-10-31T15:21:00Z

Still WIP

labels and/or draft please :)

What do you think about the idea of using appdata to store the image set in theming app? Any other/better idea?

I'm not opposed to it.
Might even be faster to serve on some filesystems.
But I'm no expert 🙈

julien-nc · 2020-11-03T10:20:43Z

labels and/or draft please :)

@skjnldsv Sorry 😅

So here it is after getting lost in the theming css maze 😁. Dashboard theming setting behaves just like the login image one. Delete button switches to plain color, revert button switches to the clouds image, upload button let admins choose a custom default dashboard background.

If dashboard app is disabled, related theming settings are hidden.
If theming app is disabled, default dashboard background will always be the clouds image.

Incorrect getAppValue default values were fixed too in theming app.

Theming app could be Vuetified ™️ but that's another story.

ChristophWurst

👍 🐘

juliusknorr · 2020-11-03T10:51:40Z

+export default (background, time = 0, themingDefaultBackground = '') => {
 	if (background === 'default') {
+ if (themingDefaultBackground && themingDefaultBackground !== 'backgroundColor') {
+ return generateUrl('/apps/theming/image/dashboardBackground') + '?v=' + time


Suggested change
returngenerateUrl('/apps/theming/image/dashboardBackground')+'?v='+time
returngenerateUrl('/apps/theming/image/dashboardBackground')+'?v='+window.OCA.Theming.cacheBuster

Good thing you mentioned that, there is a mistake at
server/apps/theming/lib/Service/JSDataService.php
Line 62 in e9af7b8
'cacheBuster' => $this->appConfig->getAppValue(Application::class, 'cachebuster', '0'),
Fixed in this branch. It will most likely solve many late favicon/icon/image refresh problems. Yay!

juliusknorr · 2020-11-03T10:55:45Z

Code looks good but I'm a bit hesitant to add yet another setting to the theming app. This is quite a special use case imo and I'd rather just reuse the themed login image and not allow another configuration option here. But up to @jancborchardt to decide.

julien-nc · 2020-11-03T12:00:40Z

Thanks for the reviews!

I'm a bit hesitant to add yet another setting to the theming app

I agree we can't add too much stuff there. I still like the possibility to set a different default background than the login one. It would feel a bit less crowded if login and dashboard sections would be side by side like that:

@jancborchardt @juliushaertl What do you think?

jancborchardt · 2020-11-10T09:06:40Z

I'm a bit hesitant to add yet another setting to the theming app. This is quite a special use case imo and I'd rather just reuse the themed login image and not allow another configuration option here.

Totally agree with @juliushaertl here – especially since there is already the ability to individually select the ones we ship as default Dashboard backgrounds, so it makes sense to just unceremoniously replace the "Default" Dashboard background with the one set by theming. :) (This would btw also help for customers, which gives a unified style by default, and based on that people can customize.)

julien-nc · 2020-11-10T11:40:39Z

@juliushaertl @jancborchardt Right, new behaviour is: If theming app is disabled or the login image is not set, no effect on the dashboard. Otherwise the dashboard default background is the same as set in theming (image or plain).

juliusknorr

👍

juliusknorr · 2020-11-12T20:50:34Z

Needs a rebase 😉

juliusknorr · 2020-11-13T06:37:23Z

/compile amend /

fix getAppValue default value in theming app fix cacheBuster value injection Signed-off-by: Julien Veyssier <eneiluj@posteo.net> Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>

julien-nc · 2020-11-13T11:35:35Z

Thanks for the reviews.

juliusknorr · 2021-02-03T08:25:51Z

/backport to stable20

ruedigerkupper · 2021-09-05T15:18:00Z

Currently, dashboard does not look good if theming is enabled and set to a light background. See #28649. Is there a way to have dark text color and dark icons for light backgrounds?

Volker-K · 2021-11-02T14:38:02Z

Why can't dashboard just use the color scheme for the application bar that every app uses?

Volker-K · 2021-11-05T10:53:54Z

Too bad that Dashboard even overrides the settings from custom-css-App.

juliusknorr · 2021-11-05T11:16:50Z

Please open new issues to discuss such things, commenting on one year old pull request will not help here.

julien-nc added enhancement 3. to review Waiting for reviews feature: dashboard labels Oct 20, 2020

kesselb linked an issue Oct 20, 2020 that may be closed by this pull request
Option to set default dashboard background in theming app #23558
Closed

kesselb removed a link to an issue Oct 20, 2020
Option to set default dashboard background in theming app #23558
Closed

skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Oct 31, 2020

julien-nc force-pushed the enh/23558/override-dashboard-default-background branch 2 times, most recently from a990f85 to 282bcf7Compare November 3, 2020 00:33

julien-nc added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 3, 2020

julien-nc requested review from ChristophWurst, jancborchardt, juliusknorr and skjnldsv November 3, 2020 10:10

ChristophWurst approved these changes Nov 3, 2020
View reviewed changes

juliusknorr reviewed Nov 3, 2020
View reviewed changes

julien-nc force-pushed the enh/23558/override-dashboard-default-background branch 2 times, most recently from 2c8b952 to 9943855Compare November 10, 2020 11:38

julien-nc requested a review from juliusknorr November 10, 2020 11:40

juliusknorr approved these changes Nov 12, 2020
View reviewed changes

julien-nc force-pushed the enh/23558/override-dashboard-default-background branch from 9943855 to c84f451Compare November 12, 2020 22:41

override default dashboard background with theming one
f5ef2d7
fix getAppValue default value in theming app fix cacheBuster value injection Signed-off-by: Julien Veyssier <eneiluj@posteo.net> Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>

npmbuildbot-nextcloudBotforce-pushed the enh/23558/override-dashboard-default-background branch from c84f451 to f5ef2d7Compare November 13, 2020 06:51

juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 13, 2020

julien-nc changed the title ~~Override default dashboard background with an appconfig switch~~Override default dashboard background with theming oneNov 13, 2020

julien-nc merged commit 2e91ccc into masterNov 13, 2020

julien-nc deleted the enh/23558/override-dashboard-default-background branch November 13, 2020 11:34

This was referenced Nov 17, 2020
Dashboard: allow andmins to define the default themes and widgets of the users dashbaord #24187
Closed
Option to set default dashboard background in theming app #23558
Closed

MorrisJobke added this to the Nextcloud 21 milestone Nov 19, 2020

backportbot-nextcloudBot added the backport-request label Feb 3, 2021

backportbot-nextcloudBot mentioned this pull request Feb 3, 2021
[stable20] Override default dashboard background with theming one #25458
Merged

backportbot-nextcloudBot removed the backport-request label Feb 3, 2021

xbluemonkx mentioned this pull request Sep 23, 2021
Can not change Default Dashboard Background #28940
Closed

almulder mentioned this pull request Nov 30, 2021
Custom default dashboard background? #29993
Closed

nextcloud locked as too heated and limited conversation to collaborators Dec 1, 2021

	returngenerateUrl('/apps/theming/image/dashboardBackground')+'?v='+time
	returngenerateUrl('/apps/theming/image/dashboardBackground')+'?v='+window.OCA.Theming.cacheBuster

Uh oh!

Uh oh!

Conversation

julien-nc commented Oct 20, 2020

Uh oh!

jancborchardt commented Oct 20, 2020

Uh oh!

lzlrd commented Oct 22, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

julien-nc commented Oct 24, 2020

Uh oh!

lzlrd commented Oct 24, 2020

Uh oh!

skjnldsv commented Oct 31, 2020

Uh oh!

julien-nc commented Oct 31, 2020

Uh oh!

skjnldsv commented Oct 31, 2020

Uh oh!

julien-nc commented Nov 3, 2020

Uh oh!

ChristophWurst left a comment

Choose a reason for hiding this comment

Uh oh!

juliusknorrNov 3, 2020

Choose a reason for hiding this comment

Uh oh!

julien-ncNov 3, 2020

Choose a reason for hiding this comment

Uh oh!

juliusknorr commented Nov 3, 2020

Uh oh!

julien-nc commented Nov 3, 2020

Uh oh!

jancborchardt commented Nov 10, 2020

Uh oh!

julien-nc commented Nov 10, 2020

Uh oh!

juliusknorr left a comment

Choose a reason for hiding this comment

Uh oh!

juliusknorr commented Nov 12, 2020

Uh oh!

juliusknorr commented Nov 13, 2020

Uh oh!

julien-nc commented Nov 13, 2020

Uh oh!

juliusknorr commented Feb 3, 2021

Uh oh!

ruedigerkupper commented Sep 5, 2021

Uh oh!

Volker-K commented Nov 2, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Volker-K commented Nov 5, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

juliusknorr commented Nov 5, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

lzlrd commented Oct 22, 2020•
edited
Loading

Volker-K commented Nov 2, 2021•
edited
Loading

Volker-K commented Nov 5, 2021•
edited
Loading