Uh oh!
There was an error while loading. Please reload this page.
Fix updates of NULL appconfig values - #23602
Merged
Merged
Conversation
The comparisson of NULL is a bit special. So we need to handle this a tad beter else it might not replace NULL values. or allow you to set NULL values on updates. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
requested review from
ChristophWurst, MorrisJobke, juliusknorr, kesselb and nickvergessenOctober 21, 2020 08:06
rullzer
commented
Oct 23, 2020
MemberAuthor
/backport to stable20 |
rullzer
commented
Oct 23, 2020
MemberAuthor
/backport to stable19 |
rullzer
commented
Oct 23, 2020
MemberAuthor
/backport to stable18 |
ChristophWurst
approved these changes
Oct 23, 2020
This was referenced Oct 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comparisson of NULL is a bit special.
So we need to handle this a tad beter else it might not replace NULL
values. or allow you to set NULL values on updates.
To test:
Sets it properly to NULL
Before: still NULL
After: 'foo'