Skip to content

Disable unreliable app-files-sharing.feature:338 - #23614

Merged
MorrisJobke merged 1 commit into
masterfrom
tests/22305/unreliable-app-files-sharing-338
Oct 22, 2020
Merged

Disable unreliable app-files-sharing.feature:338#23614
MorrisJobke merged 1 commit into
masterfrom
tests/22305/unreliable-app-files-sharing-338

Conversation

@MorrisJobke

@MorrisJobkeMorrisJobke commented Oct 21, 2020

Copy link
Copy Markdown
Member

#22305 (comment)

cc @danxuliu sorry, but it fails quite often and it just hurts the other CI jobs.

@MorrisJobke
Disable unreliable app-files-sharing.feature:108
dff9853
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobkeMorrisJobke added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Oct 21, 2020
@MorrisJobkeMorrisJobke added this to the Nextcloud 21 milestone Oct 21, 2020
@MorrisJobke

MorrisJobke commented Oct 21, 2020

Copy link
Copy Markdown
MemberAuthor

/backport to stable20

@MorrisJobke

MorrisJobke commented Oct 21, 2020

Copy link
Copy Markdown
MemberAuthor

/backport to stable19

@MorrisJobke

MorrisJobke commented Oct 21, 2020

Copy link
Copy Markdown
MemberAuthor

/backport to stable18

@MorrisJobkeMorrisJobke mentioned this pull request Oct 21, 2020
Closed
@faily-bot

faily-botBot commented Oct 21, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34421: failure

mariadb10.1-php7.3

Show full log
There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
--
There was 1 failure:
1) Test\Files\Cache\QuerySearchHelperTest::testComparison with data set #4 (OC\Files\Search\SearchComparison Object (...), array(0))
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
Array (
- 0 => 0
+ 0 => '431'
)
/drone/src/tests/lib/Files/Cache/QuerySearchHelperTest.php:212

danxuliu
danxuliu approved these changes Oct 22, 2020
View reviewed changes

@danxuliudanxuliu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @danxuliu sorry, but it fails quite often and it just hurts the other CI jobs.

No problem, thanks for doing the clean up :-)

@MorrisJobke
MorrisJobke merged commit a747057 into masterOct 22, 2020
@MorrisJobke
MorrisJobke deleted the tests/22305/unreliable-app-files-sharing-338 branch October 22, 2020 10:19
This was referenced Oct 22, 2020
Merged
Merged
Merged
@danxuliudanxuliu changed the title Disable unreliable app-files-sharing.feature:108Disable unreliable app-files-sharing.feature:338Oct 22, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@danxuliudanxuliudanxuliu approved these changes
@rullzerrullzerAwaiting requested review from rullzer

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewstechnical debt🧱 🤔🚀

Projects

None yet

Milestone

Nextcloud 21

Development

Successfully merging this pull request may close these issues.

4 participants

@MorrisJobke@ChristophWurst@skjnldsv@danxuliu