Skip to content

[stable19] Disable unreliable app-files.feature:108 - #23623

Merged
MorrisJobke merged 1 commit into
stable19from
backport/23613/stable19
Oct 22, 2020
Merged

[stable19] Disable unreliable app-files.feature:108#23623
MorrisJobke merged 1 commit into
stable19from
backport/23613/stable19

Conversation

@backportbot-nextcloud

@backportbot-nextcloudbackportbot-nextcloudBot commented Oct 22, 2020

Copy link
Copy Markdown

backport of #23613

@MorrisJobke@backportbot
Disable unreliable app-files.feature:108
56b0dc0
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@backportbot-nextcloudbackportbot-nextcloudBot added the technical debt 🧱 🤔🚀 label Oct 22, 2020
@backportbot-nextcloudbackportbot-nextcloudBot added this to the Nextcloud 19.0.5 milestone Oct 22, 2020
@MorrisJobkeMorrisJobke added the 3. to review Waiting for reviews label Oct 22, 2020
@faily-bot

faily-botBot commented Oct 22, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34443: failure

mysql5.6-php7.2

Show full log
There was 1 error:
1) OCA\FederatedFileSharing\Tests\FederatedShareProviderTest::testCreateAlreadyShared
OCP\Share\Exceptions\ShareNotFound: There was an error retrieving the share. Maybe the link is wrong, it was unshared, or it was deleted.
/drone/src/apps/federatedfilesharing/lib/FederatedShareProvider.php:863
/drone/src/apps/federatedfilesharing/lib/FederatedShareProvider.php:242
/drone/src/apps/federatedfilesharing/tests/FederatedShareProviderTest.php:406
--
There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

@MorrisJobkeMorrisJobke mentioned this pull request Oct 22, 2020
Closed
@danxuliudanxuliu added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 22, 2020
@MorrisJobke
MorrisJobke merged commit 4576158 into stable19Oct 22, 2020
@MorrisJobke
MorrisJobke deleted the backport/23613/stable19 branch October 22, 2020 13:57
@rullzerrullzer mentioned this pull request Nov 9, 2020
Merged
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@danxuliudanxuliudanxuliu approved these changes
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst
@kesselbkesselbAwaiting requested review from kesselb
@rullzerrullzerAwaiting requested review from rullzer
@skjnldsvskjnldsvAwaiting requested review from skjnldsv

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishtechnical debt🧱 🤔🚀

Projects

None yet

Milestone

Nextcloud 19.0.5

Development

Successfully merging this pull request may close these issues.

2 participants

@MorrisJobke@danxuliu