Skip to content

Fix sharing input placeholder for emails - #23627

Merged
skjnldsv merged 1 commit into
masterfrom
fix/autocomplete-placeholder-email
Oct 23, 2020
Merged

Fix sharing input placeholder for emails#23627
skjnldsv merged 1 commit into
masterfrom
fix/autocomplete-placeholder-email

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Oct 22, 2020

Copy link
Copy Markdown
Member

Because we can always get a user by its email

@skjnldsvskjnldsv self-assigned this Oct 22, 2020
@skjnldsv

skjnldsv commented Oct 22, 2020

Copy link
Copy Markdown
MemberAuthor

/compile amend /

@skjnldsv

skjnldsv commented Oct 22, 2020

Copy link
Copy Markdown
MemberAuthor

/backport to stable20

@skjnldsv

skjnldsv commented Oct 22, 2020

Copy link
Copy Markdown
MemberAuthor

/backport to stable19

@skjnldsv

skjnldsv commented Oct 22, 2020

Copy link
Copy Markdown
MemberAuthor

/backport to stable18

@skjnldsvskjnldsv added this to the Nextcloud 21 milestone Oct 22, 2020
@npmbuildbot-nextcloud
npmbuildbot-nextcloudBotforce-pushed the fix/autocomplete-placeholder-email branch from 2985876 to bd8193cCompareOctober 22, 2020 10:48
MorrisJobke
MorrisJobke approved these changes Oct 22, 2020
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

jancborchardt
jancborchardt reviewed Oct 22, 2020
View reviewed changes
Comment threadapps/files_sharing/src/components/SharingInput.vue Outdated
@skjnldsv
skjnldsvforce-pushed the fix/autocomplete-placeholder-email branch from bd8193c to f7eec28CompareOctober 23, 2020 10:27
@faily-bot

faily-botBot commented Oct 23, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34484: failure

mariadb10.1-php7.3

Show full log
There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
--
There was 1 failure:
1) Test\Share20\DefaultShareProviderTest::testDeleteFromSelfLink
Failed asserting that exception of type "OCP\Share\Exceptions\ShareNotFound" matches expected exception "OC\Share20\Exception\ProviderException". Message was: "There was an error retrieving the share. Maybe the link is wrong, it was unshared, or it was deleted." at
/drone/src/lib/private/Share20/DefaultShareProvider.php:763
/drone/src/tests/lib/Share20/DefaultShareProviderTest.php:1770
.

@MorrisJobkeMorrisJobke mentioned this pull request Oct 23, 2020
Closed
@MorrisJobke

MorrisJobke commented Oct 23, 2020

Copy link
Copy Markdown
Member

/compile amend /

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 23, 2020
@skjnldsv@npmbuildbot
Fix sharing input placeholder for emails
f0c47bf
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@npmbuildbot-nextcloud
npmbuildbot-nextcloudBotforce-pushed the fix/autocomplete-placeholder-email branch from f7eec28 to f0c47bfCompareOctober 23, 2020 11:48
@skjnldsv
skjnldsv merged commit 2a154f5 into masterOct 23, 2020
@skjnldsv
skjnldsv deleted the fix/autocomplete-placeholder-email branch October 23, 2020 12:40
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Oct 23, 2020
Merged
This was referenced Oct 23, 2020
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@jancborchardtjancborchardtjancborchardt approved these changes
@rullzerrullzerAwaiting requested review from rullzer
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst
@marcoambrosinimarcoambrosiniAwaiting requested review from marcoambrosini

Assignees

@skjnldsvskjnldsv

Labels

4. to releaseReady to be released and/or waiting for tests to finishfeature: sharing

Projects

None yet

Milestone

Nextcloud 21

Development

Successfully merging this pull request may close these issues.

3 participants

@skjnldsv@MorrisJobke@jancborchardt