Uh oh!
There was an error while loading. Please reload this page.
Check if array elements exist before using them - #23645
Merged
Merged
Conversation
rullzer
requested review from
MorrisJobke, icewind1991, juliusknorr and nickvergessenOctober 23, 2020 10:43
MorrisJobkeforce-pushed
the
fix/fe/s3/isset_first
branch
from
October 23, 2020 11:44
6039965 to
3b26178CompareMorrisJobke
commented
Oct 23, 2020
Member
I amended your commit, because there was one additional space behind the if statement. |
kesselb
commented
Oct 23, 2020
Contributor
Looks similar to #23591 🤔 |
kesselb
requested changes
Oct 23, 2020
Uh oh!
There was an error while loading. Please reload this page.
rullzerforce-pushed
the
fix/fe/s3/isset_first
branch
from
October 24, 2020 08:13
3b26178 to
47c60a1CompareIt seems that in some recent upgrade here. Not always the entries we expect are returned. So we should first check if they exist. As to not spam the log. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
MorrisJobkeforce-pushed
the
fix/fe/s3/isset_first
branch
from
October 25, 2020 21:03
47c60a1 to
b7be09aCompareMorrisJobke
commented
Oct 25, 2020
Member
Did it again, because you overwrote it 😝 |
MorrisJobke
approved these changes
Oct 25, 2020
rullzer
commented
Oct 26, 2020
MemberAuthor
/backport to stable20 |
rullzer
commented
Oct 26, 2020
MemberAuthor
/backport to stable19 |
rullzer
commented
Oct 26, 2020
MemberAuthor
/backport to stable18 |
nickvergessen
approved these changes
Oct 27, 2020
This was referenced Oct 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that in some recent upgrade here. Not always the entries we
expect are returned. So we should first check if they exist. As to not
spam the log.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl