Skip to content

[stable19] fix sharer flag on ldap:show-remnants when user owned more than a single share - #23708

Merged
MorrisJobke merged 3 commits into
stable19from
backport/23702/stable19
Oct 27, 2020
Merged

[stable19] fix sharer flag on ldap:show-remnants when user owned more than a single share#23708
MorrisJobke merged 3 commits into
stable19from
backport/23702/stable19

Conversation

@backportbot-nextcloud

@backportbot-nextcloudbackportbot-nextcloudBot commented Oct 27, 2020

Copy link
Copy Markdown

backport of #23702

@blizzz@backportbot
add test for active shares flag
394ec56
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz@backportbot
split instantiation from business logic in OfflineUser
7544f0c
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz@backportbot
fixes determining whether former user is a share owner
9c5bd23
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@backportbot-nextcloudbackportbot-nextcloudBot added this to the Nextcloud 19.0.5 milestone Oct 27, 2020
@blizzzblizzz changed the title [stable19] [stable20] fix sharer flag on ldap:show-remnants when user owned more than a single share[stable19] fix sharer flag on ldap:show-remnants when user owned more than a single shareOct 27, 2020
@MorrisJobkeMorrisJobke added the 4. to release Ready to be released and/or waiting for tests to finish label Oct 27, 2020
@faily-bot

faily-botBot commented Oct 27, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34595: failure

mariadb10.1-php7.2

Show full log
There was 1 error:
1) Test\Comments\ManagerTest::testDeleteCommentsAtObject
InvalidArgumentException: IDs must be translatable to a number in this implementation.
/drone/src/lib/private/Comments/Manager.php:248
/drone/src/tests/lib/Comments/ManagerTest.php:664
--
There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

@MorrisJobkeMorrisJobke mentioned this pull request Oct 27, 2020
Closed
@MorrisJobke
MorrisJobke merged commit 9007a8a into stable19Oct 27, 2020
@MorrisJobke
MorrisJobke deleted the backport/23702/stable19 branch October 27, 2020 12:52
@rullzerrullzer mentioned this pull request Nov 9, 2020
Merged
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blizzzblizzzblizzz approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@MorrisJobkeMorrisJobkeAwaiting requested review from MorrisJobke
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@rullzerrullzerAwaiting requested review from rullzer

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: ldap

Projects

None yet

Milestone

Nextcloud 19.0.5

Development

Successfully merging this pull request may close these issues.

3 participants

@blizzz@skjnldsv@MorrisJobke