Uh oh!
There was an error while loading. Please reload this page.
expand 'path is already shared' error message - #23718
Merged
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
MorrisJobke
commented
Oct 27, 2020
Member
Also CI fails due to the changed message. |
icewind1991force-pushed
the
already-shared-error-message
branch
2 times, most recently
from
October 29, 2020 12:22
a18de89 to
b254385Compare| } | ||
| // Identical share already existst | ||
| // Identical share already exist |
Member
There was a problem hiding this comment.
Suggested change
| // Identical share already exist | |
| // Identical share already exists |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
MorrisJobke
commented
Mar 15, 2021
Member
Conflicts with #25533 |
| use OC\HintException; | ||
| use OCP\IL10N; | ||
| class AlreadyShared extends HintException { |
Member
There was a problem hiding this comment.
Let me drop this commit, as it was already implemented in #25533
MorrisJobkeforce-pushed
the
already-shared-error-message
branch
2 times, most recently
from
March 15, 2021 14:34
39f849a to
6213473CompareSigned-off-by: Robin Appelman <robin@icewind.nl>
MorrisJobkeforce-pushed
the
already-shared-error-message
branch
from
March 15, 2021 14:55
6213473 to
a550649CompareMorrisJobke
approved these changes
Mar 15, 2021
MorrisJobke
left a comment
Member
There was a problem hiding this comment.
I rebased it and used the changes from #25533 in here instead of reimplementing it 👍
MorrisJobke
commented
Mar 15, 2021
Member
/backport to stable20 |
MorrisJobke
commented
Mar 15, 2021
Member
/backport to stable21 |
rullzer
approved these changes
Mar 19, 2021
This was referenced Mar 19, 2021
skjnldsv
commented
Mar 19, 2021
Member
Noooooooooo |
MorrisJobke
commented
Mar 19, 2021
Member
No? :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Robin Appelman robin@icewind.nl