Skip to content

inform the user when flow config data exceeds thresholds - #23752

Merged
blizzz merged 1 commit into
masterfrom
fix/noid/wfe-ux-errors
Oct 28, 2020
Merged

inform the user when flow config data exceeds thresholds#23752
blizzz merged 1 commit into
masterfrom
fix/noid/wfe-ux-errors

Conversation

@blizzz

Copy link
Copy Markdown
Member

When providing check values or operation data (the stuff for action), you'll be informed when sending too much. The limits are now 2 and 4kB respectively, which should be sufficient for any flow configuration. Um, … ever ;)

Screenshot_20201028_140922

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 28, 2020
@faily-bot

faily-botBot commented Oct 28, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34686: failure

mariadb10.1-php7.3

Show full log
There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
--
There was 1 failure:
1) OCA\DAV\Tests\unit\CardDAV\CardDavBackendTest::testSearch with data set "case insensitive" ('john', array('FN'), array(), array(array('uri0', 'John Doe'), array('uri1', 'John M. Doe')))
Failed asserting that 1 is identical to 2.
/drone/src/apps/dav/tests/unit/CardDAV/CardDavBackendTest.php:746

mariadb10.4-php7.4

Show full log
There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
--
There was 1 failure:
1) Test\Files\Cache\ScannerTest::testBackgroundScanNestedIncompleteFolders
Failed asserting that false is true.
/drone/src/tests/lib/Files/Cache/ScannerTest.php:220

@blizzzblizzz mentioned this pull request Oct 28, 2020
@blizzz
blizzz merged commit 6b2cf46 into masterOct 28, 2020
@blizzz
blizzz deleted the fix/noid/wfe-ux-errors branch October 28, 2020 15:05
@blizzz

Copy link
Copy Markdown
MemberAuthor

/backport to stable20

@blizzz

Copy link
Copy Markdown
MemberAuthor

/backport to stable19

@blizzz

Copy link
Copy Markdown
MemberAuthor

/backport to stable18

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@blizzz@rullzer@nickvergessen@MorrisJobke