Skip to content

Document settings BeforeTemplateRenderedEvent - #23778

Merged
rullzer merged 1 commit into
masterfrom
doc/22649/document-settings-before-template-event
Oct 29, 2020
Merged

Document settings BeforeTemplateRenderedEvent#23778
rullzer merged 1 commit into
masterfrom
doc/22649/document-settings-before-template-event

Conversation

@MorrisJobke

Copy link
Copy Markdown
Member

Ref #22649

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO should be in \OCP if this is meant to be an event to consume by apps

@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

IMO should be in \OCP if this is meant to be an event to consume by apps

We have quite some other events in the OCA namespace right now. Let's tackle this then in a followup.

@rullzer
rullzer merged commit 9b15b66 into masterOct 29, 2020
@rullzer
rullzer deleted the doc/22649/document-settings-before-template-event branch October 29, 2020 18:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@MorrisJobke@rullzer@ChristophWurst