Skip to content

Only run phpunit when "php" changed - #23788

Merged
MorrisJobke merged 3 commits into
masterfrom
techdebt/noid/only-run-phpunit-when-php-changed
Oct 30, 2020
Merged

Only run phpunit when "php" changed#23788
MorrisJobke merged 3 commits into
masterfrom
techdebt/noid/only-run-phpunit-when-php-changed

Conversation

@nickvergessen

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessennickvergessen added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Oct 30, 2020
@nickvergessennickvergessen added this to the Nextcloud 21 milestone Oct 30, 2020

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also changes to .sh files should be taken as valid test cases (looking at autotest.sh here)

@MorrisJobke

Copy link
Copy Markdown
Member

And .json like the shipped.json

@nickvergessen

Copy link
Copy Markdown
MemberAuthor

json is meh, but I will check for not package.json and package-lock.json

Signed-off-by: Joas Schilling <coding@schilljs.com>
@MorrisJobke
MorrisJobke merged commit f94af85 into masterOct 30, 2020
@MorrisJobke
MorrisJobke deleted the techdebt/noid/only-run-phpunit-when-php-changed branch October 30, 2020 12:06
@MorrisJobke

Copy link
Copy Markdown
Member

/backport to stable20

@MorrisJobke

Copy link
Copy Markdown
Member

/backport to stable19

@MorrisJobke

Copy link
Copy Markdown
Member

/backport to stable18

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewstechnical debt🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen@MorrisJobke@rullzer