LDAP: fix null where IUser is expected in update groups background job

[blizzz]

This can happen when a user was already removed, but the DB table was having old information. Previously – with the old events – it did not cause a problem, because an old user id was passed. Now, an IUser object was required. Comes with tests and thus some refactoring against the necessary methods of the job. The actual fix is the second commit.

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34809: failure

mysql8.0-php7.4

Show full log

There was 1 error:
1) Test\Files\Storage\Wrapper\PermissionsMaskTest::testScanNewWrappedFiles
Error: Call to a member function getPermissions() on bool
/drone/src/tests/lib/Files/Storage/Wrapper/PermissionsMaskTest.php:126
--
There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

[skjnldsv]

🐘

[rullzer]

even test.
🐘

[ChristophWurst]

Code looks good

[ChristophWurst]

you could use array_map :)

[blizzz]

yes. doesn't make much difference, but perhaps lookin a bit fancier than good ol' foreach. iirc it is also more memory hungry than foreach.

[ChristophWurst]

who cares about memory footprint if you can have fancy 😉

for me it's mostly about readability. If I see an array_map I immediately can guess what's happening.

[blizzz]

Actually can be a concern, depending how users and groups you throw on it. In this case the readability wouldn't really change as it is a one-line-transformation of the result array, either way.

[blizzz]

/backport to stable20

[blizzz]

/backport to stable19

[blizzz]

/backport to stable18