Uh oh!
There was an error while loading. Please reload this page.
Do not setup the default FS on normal routes - #23821
Merged
Merged
Conversation
rullzer
requested review from
MorrisJobke, icewind1991, juliusknorr and nickvergessenOctober 31, 2020 14:12
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 34839: failureintegration-comments-search
Show full log |
juliusknorr
approved these changes
Nov 2, 2020
MorrisJobke
commented
Nov 5, 2020
Member
I would expect it to cause more issues on the endpoints that use the non-node base API, right? Also the getstoragestats endpoint seem to fail: {"Exception":"Exception","Message":"Call to a member function getFileInfo() on null","Code":0,"Trace":[{"file":"\/Users\/morris\/Projects\/nextcloud\/server\/lib\/private\/AppFramework\/App.php","line":157,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\Files\\Controller\\AjaxController"},"getStorageStats"]},{"file":"\/Users\/morris\/Projects\/nextcloud\/server\/lib\/private\/Route\/Router.php","line":308,"function":"main","class":"OC\\AppFramework\\App","type":"::","args":["OCA\\Files\\Controller\\AjaxController","getStorageStats",{"__class__":"OC\\AppFramework\\DependencyInjection\\DIContainer"},{"action":null,"_route":"files.ajax.getStorageStats"}]},{"file":"\/Users\/morris\/Projects\/nextcloud\/server\/lib\/base.php","line":1009,"function":"match","class":"OC\\Route\\Router","type":"->","args":["\/apps\/files\/ajax\/getstoragestats.php"]},{"file":"\/Users\/morris\/Projects\/nextcloud\/server\/index.php","line":37,"function":"handleRequest","class":"OC","type":"::","args":[]}],"File":"\/Users\/morris\/Projects\/nextcloud\/server\/lib\/private\/AppFramework\/Http\/Dispatcher.php","Line":159,"Previous":{"Exception":"Error","Message":"Call to a member function getFileInfo() on null","Code":0,"Trace":[{"file":"\/Users\/morris\/Projects\/nextcloud\/server\/lib\/private\/legacy\/OC_Helper.php","line":488,"function":"getFileInfo","class":"OC\\Files\\Filesystem","type":"::","args":["\/",false]},{"file":"\/Users\/morris\/Projects\/nextcloud\/server\/apps\/files\/lib\/Helper.php","line":51,"function":"getStorageInfo","class":"OC_Helper","type":"::","args":["\/"]},{"file":"\/Users\/morris\/Projects\/nextcloud\/server\/apps\/files\/lib\/Controller\/AjaxController.php","line":47,"function":"buildFileStorageStatistics","class":"OCA\\Files\\Helper","type":"::","args":["\/"]},{"file":"\/Users\/morris\/Projects\/nextcloud\/server\/lib\/private\/AppFramework\/Http\/Dispatcher.php","line":218,"function":"getStorageStats","class":"OCA\\Files\\Controller\\AjaxController","type":"->","args":["\/"]},{"file":"\/Users\/morris\/Projects\/nextcloud\/server\/lib\/private\/AppFramework\/Http\/Dispatcher.php","line":127,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\Files\\Controller\\AjaxController"},"getStorageStats"]},{"file":"\/Users\/morris\/Projects\/nextcloud\/server\/lib\/private\/AppFramework\/App.php","line":157,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\Files\\Controller\\AjaxController"},"getStorageStats"]},{"file":"\/Users\/morris\/Projects\/nextcloud\/server\/lib\/private\/Route\/Router.php","line":308,"function":"main","class":"OC\\AppFramework\\App","type":"::","args":["OCA\\Files\\Controller\\AjaxController","getStorageStats",{"__class__":"OC\\AppFramework\\DependencyInjection\\DIContainer"},{"action":null,"_route":"files.ajax.getStorageStats"}]},{"file":"\/Users\/morris\/Projects\/nextcloud\/server\/lib\/base.php","line":1009,"function":"match","class":"OC\\Route\\Router","type":"->","args":["\/apps\/files\/ajax\/getstoragestats.php"]},{"file":"\/Users\/morris\/Projects\/nextcloud\/server\/index.php","line":37,"function":"handleRequest","class":"OC","type":"::","args":[]}],"File":"\/Users\/morris\/Projects\/nextcloud\/server\/lib\/private\/Files\/Filesystem.php","Line":864},"CustomMessage":"--"} |
rullzer
commented
Nov 5, 2020
MemberAuthor
Yes we should fix that. But the issue here is that at some point we need to make a switch. Else we keep setting up the storage on those routes untill the end of days. The main issue is that it happens so early so we can't even have routes opt out or in via an annotation. |
MorrisJobke
commented
Nov 5, 2020
Member
Full ack. We just should fix our endpoints then also in this PR here. |
This should help with load times hopefully. Only initialize the FS if we actually ned it. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzerforce-pushed
the
td/enh/no_fs_setup_by_default
branch
from
November 6, 2020 08:03
f9bbef0 to
448044dComparerullzer
commented
Nov 6, 2020
MemberAuthor
Fixed that |
MorrisJobke
commented
Nov 6, 2020
Member
I added it to #23210 for visibility. |
skjnldsv
commented
Nov 7, 2020
Member
I think it broke |
skjnldsv
commented
Nov 7, 2020
Member
{
"Exception": "Exception",
"Message": "Call to a member function search() on null",
"Code": 0,
"Trace": [
{
"file": "/drone/src/lib/private/AppFramework/App.php",
"line": 157,
"function": "dispatch",
"class": "OC\\AppFramework\\Http\\Dispatcher",
"type": "->",
"args": [
{
"__class__": "OC\\Core\\Controller\\SearchController"
},
"search"
]
},
{
"file": "/drone/src/lib/private/Route/Router.php",
"line": 309,
"function": "main",
"class": "OC\\AppFramework\\App",
"type": "::",
"args": [
"OC\\Core\\Controller\\SearchController",
"search",
{
"__class__": "OC\\AppFramework\\DependencyInjection\\DIContainer"
},
{
"action": null,
"_route": "core.Search.search"
}
]
},
{
"file": "/drone/src/lib/base.php",
"line": 1009,
"function": "match",
"class": "OC\\Route\\Router",
"type": "->",
"args": [
"/core/search"
]
},
{
"file": "/drone/src/index.php",
"line": 37,
"function": "handleRequest",
"class": "OC",
"type": "::",
"args": []
}
],
"File": "/drone/src/lib/private/AppFramework/Http/Dispatcher.php",
"Line": 159,
"Previous": {
"Exception": "Error",
"Message": "Call to a member function search() on null",
"Code": 0,
"Trace": [
{
"file": "/drone/src/lib/private/Search/Provider/File.php",
"line": 47,
"function": "search",
"class": "OC\\Files\\Filesystem",
"type": "::",
"args": [
"first"
]
},
{
"file": "/drone/src/lib/private/Search.php",
"line": 61,
"function": "search",
"class": "OC\\Search\\Provider\\File",
"type": "->",
"args": [
"first"
]
},
{
"file": "/drone/src/core/Controller/SearchController.php",
"line": 60,
"function": "searchPaged",
"class": "OC\\Search",
"type": "->",
"args": [
"first",
[
"files"
],
1,
30
]
},
{
"file": "/drone/src/lib/private/AppFramework/Http/Dispatcher.php",
"line": 218,
"function": "search",
"class": "OC\\Core\\Controller\\SearchController",
"type": "->",
"args": [
"first",
[
"files"
],
1,
30
]
},
{
"file": "/drone/src/lib/private/AppFramework/Http/Dispatcher.php",
"line": 127,
"function": "executeController",
"class": "OC\\AppFramework\\Http\\Dispatcher",
"type": "->",
"args": [
{
"__class__": "OC\\Core\\Controller\\SearchController"
},
"search"
]
},
{
"file": "/drone/src/lib/private/AppFramework/App.php",
"line": 157,
"function": "dispatch",
"class": "OC\\AppFramework\\Http\\Dispatcher",
"type": "->",
"args": [
{
"__class__": "OC\\Core\\Controller\\SearchController"
},
"search"
]
},
{
"file": "/drone/src/lib/private/Route/Router.php",
"line": 309,
"function": "main",
"class": "OC\\AppFramework\\App",
"type": "::",
"args": [
"OC\\Core\\Controller\\SearchController",
"search",
{
"__class__": "OC\\AppFramework\\DependencyInjection\\DIContainer"
},
{
"action": null,
"_route": "core.Search.search"
}
]
},
{
"file": "/drone/src/lib/base.php",
"line": 1009,
"function": "match",
"class": "OC\\Route\\Router",
"type": "->",
"args": [
"/core/search"
]
},
{
"file": "/drone/src/index.php",
"line": 37,
"function": "handleRequest",
"class": "OC",
"type": "::",
"args": []
}
],
"File": "/drone/src/lib/private/Files/Filesystem.php",
"Line": 763
},
"CustomMessage": "--"
} |
rullzer
commented
Nov 9, 2020
MemberAuthor
could be let me check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should help with load times hopefully. Only initialize the FS if we
actually ned it.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl