Skip to content

[stable19] Inidicate preview availability in share api responses - #23860

Merged
rullzer merged 1 commit into
stable19from
backport/23350/stable19
Nov 6, 2020
Merged

[stable19] Inidicate preview availability in share api responses#23860
rullzer merged 1 commit into
stable19from
backport/23350/stable19

Conversation

@backportbot-nextcloud

@backportbot-nextcloudbackportbot-nextcloudBot commented Nov 3, 2020

Copy link
Copy Markdown

⚠️ This backport had conflicts and is incomplete ⚠️ JS compile should fix this - some PHP unit test changes are not in here - most likely because those tests are 20+ only

backport of #23350

@MorrisJobke

Copy link
Copy Markdown
Member

/compile amend /

@MorrisJobkeMorrisJobke added the 3. to review Waiting for reviews label Nov 3, 2020
@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 3, 2020
@MorrisJobke

Copy link
Copy Markdown
Member

/compile amend /

@MorrisJobke

Copy link
Copy Markdown
Member

CI says no :(

@MorrisJobkeMorrisJobke added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Nov 4, 2020
@st3iny

Copy link
Copy Markdown
Member

php-cs lint fails with:

In ToolInfo.php line 50:
Undefined index: name

I didn't touch that file :(

@MorrisJobke

Copy link
Copy Markdown
Member

php-cs lint fails with:

Sometimes it's behaving like that, but we are unsure, what is triggering this yet. Just ignore it for now as it is a cherry-picked backport.

@MorrisJobke

This comment has been minimized.

@st3inyst3iny self-assigned this Nov 4, 2020
@st3iny
st3inyforce-pushed the backport/23350/stable19 branch from 2718466 to d45ef86CompareNovember 5, 2020 21:42
@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Nov 5, 2020
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny
st3inyforce-pushed the backport/23350/stable19 branch from d45ef86 to af5a94dCompareNovember 5, 2020 23:11
@rullzer
rullzer merged commit ae99412 into stable19Nov 6, 2020
@rullzer
rullzer deleted the backport/23350/stable19 branch November 6, 2020 07:39
@rullzerrullzer mentioned this pull request Nov 9, 2020
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@MorrisJobke@st3iny@juliusknorr@skjnldsv@rullzer