Skip to content

Fix js search in undefined ocs response - #23981

Merged
MorrisJobke merged 1 commit into
masterfrom
fix/sharing/undefined-in-search
Nov 9, 2020
Merged

Fix js search in undefined ocs response#23981
MorrisJobke merged 1 commit into
masterfrom
fix/sharing/undefined-in-search

Conversation

@skjnldsv

Copy link
Copy Markdown
Member

Fixnextcloud/circles#510

If the backend fail, the search cannot work on an undefined variable.

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/compile amend /

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/backport to stable20

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/backport to stable19

@npmbuildbot-nextcloud
npmbuildbot-nextcloudBotforce-pushed the fix/sharing/undefined-in-search branch from d24d818 to 65ac9f8CompareNovember 7, 2020 22:45
@rullzer

This comment has been minimized.

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
@skjnldsv
skjnldsvforce-pushed the fix/sharing/undefined-in-search branch from 65ac9f8 to 53e56b4CompareNovember 9, 2020 11:31
@skjnldsv

Copy link
Copy Markdown
MemberAuthor

Rebased

@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 9, 2020
@skjnldsvskjnldsv mentioned this pull request Nov 9, 2020
@MorrisJobke
MorrisJobke merged commit 92ddaea into masterNov 9, 2020
@MorrisJobke
MorrisJobke deleted the fix/sharing/undefined-in-search branch November 9, 2020 18:41
@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/backport to stable18

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: sharing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Getting message "Error creating the share" when sharing a file despite the share is created correctly

3 participants

@skjnldsv@rullzer@MorrisJobke